You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "XorSum (via GitHub)" <gi...@apache.org> on 2025/08/28 09:05:13 UTC
[PR] add `--skipBuildNative` option to `auron-build.sh` [auron]
XorSum opened a new pull request, #1235:
URL: https://github.com/apache/auron/pull/1235
<!--
- Licensed to the Apache Software Foundation (ASF) under one or more
- contributor license agreements. See the NOTICE file distributed with
- this work for additional information regarding copyright ownership.
- The ASF licenses this file to You under the Apache License, Version 2.0
- (the "License"); you may not use this file except in compliance with
- the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-->
# Which issue does this PR close?
If we want to only build Scala/Java code (in order to save time), we can skip building the Rust code.
To help more users be aware of this functionality, I have added the `--skipBuildNative` option to the `auron-build.sh` script.
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
# How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add `--skipBuildNative` option to `auron-build.sh` [auron]
Posted by "XorSum (via GitHub)" <gi...@apache.org>.
XorSum commented on PR #1235:
URL: https://github.com/apache/auron/pull/1235#issuecomment-3235882066
> I remain neutral. I think we can add `-DskipBuildNative` in the usage example.
Good suggestion! I have removed the option and added the usage example with `-DskipBuildNative`. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add `--skipBuildNative` option to `auron-build.sh` [auron]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #1235:
URL: https://github.com/apache/auron/pull/1235#issuecomment-3233831158
Hi @XorSum
I think we can add `-DskipBuildNative` in the example, not needed to extend the options any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add `--skipBuildNative` option to `auron-build.sh` [auron]
Posted by "XorSum (via GitHub)" <gi...@apache.org>.
XorSum commented on PR #1235:
URL: https://github.com/apache/auron/pull/1235#issuecomment-3233128146
> Thanks for the input. As discussed earlier, we don’t need to extend the build script for additional Maven options since #1209 has already added passthrough support. Kindly cc @turboFei
Thanks for the feedback. The primary purpose of this PR is to make the `skipBuildNative` option more visible to new contributors. Currently this useful option is somewhat hidden in `spark-extension/pom.xml`, which might not be obvious to new contributors. By adding it to `auron-build.sh`, we can help new contributors discover this option more quickly, thereby enhancing the onboarding experience for contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add `--skipBuildNative` option to `auron-build.sh` [auron]
Posted by "merrily01 (via GitHub)" <gi...@apache.org>.
merrily01 commented on PR #1235:
URL: https://github.com/apache/auron/pull/1235#issuecomment-3232933438
Thanks for the input. As discussed earlier, we don’t need to extend the build script for additional Maven options since #1209 has already added passthrough support. Kindly cc @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] `auron-build.sh` add usage example of `-DskipBuildNative` [auron]
Posted by "XorSum (via GitHub)" <gi...@apache.org>.
XorSum commented on PR #1235:
URL: https://github.com/apache/auron/pull/1235#issuecomment-3235945009
> LGTM, could you update the PR title and description?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] `auron-build.sh` add usage example of `-DskipBuildNative` [auron]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 merged PR #1235:
URL: https://github.com/apache/auron/pull/1235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org