[GitHub] [superset] zhaoyongjie commented on pull request #20891: feat: Adds drill to detail context menu for ECharts visualizations

[GitBox <gi...@apache.org>]

zhaoyongjie commented on PR #20891:
URL: https://github.com/apache/superset/pull/20891#issuecomment-1197570625

   @michael-s-molina Looking at the screenshot, there is one thing that needs to be added. When a `time dimension` is clicked with `time grain` applied, the `time grain` needs to be passed at the same time. 
   
   BTW, why needs a `formattedVal` in the filter?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org