You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Clément Mondon <cl...@inria.fr> on 2013/04/04 12:39:08 UTC

Review Request: OSX Support with vSphere5.1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10137/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Add OS X 10.6 and 10.7 support on VSphere 5.1 clusters (vSphere 5.1 officially support OSX Guests).

To run OS X guest instances, this patch defines several extra options passed to the vmx file : 
- Emulate SMC device
- Use EFI
- root disk controller must be scsi

This patch modifies "VMwareGuru.java", previously modified by commit f7b600b43921ee2324e049432c9cf18906fc6772, to allow overwriting the global setting "vmware.root.disk.controller" when vmware.root.disk.controller is defined in the template definition. 


This addresses bug CLOUDSTACK-1933.


Diffs
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java bb7c297 
  server/src/com/cloud/vm/UserVmManagerImpl.java 82a69bd 
  setup/db/db/schema-410to420.sql 9eed0a6 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 04b4d8e 

Diff: https://reviews.apache.org/r/10137/diff/


Testing
-------

Tested with Vsphere 5.1, Hypervisor (ESXi) installed on a mac mini. Working with OSX 10.6 and 10.7.


Thanks,

Clément Mondon


Re: Review Request: OSX Support with vSphere5.1

Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10137/#review18912
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On April 4, 2013, 1:28 p.m., Clément Mondon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10137/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 1:28 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Add OS X 10.6 and 10.7 support on VSphere 5.1 clusters (vSphere 5.1 officially support OSX Guests).
> 
> To run OS X guest instances, this patch defines several extra options passed to the vmx file : 
> - Emulate SMC device
> - Use EFI
> - root disk controller must be scsi
> 
> This patch modifies "VMwareGuru.java", previously modified by commit f7b600b43921ee2324e049432c9cf18906fc6772, to allow overwriting the global setting "vmware.root.disk.controller" when vmware.root.disk.controller is defined in the template definition. 
> 
> 
> This addresses bug CLOUDSTACK-1933.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java bb7c297 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 82a69bd 
>   setup/db/db/schema-410to420.sql 9eed0a6 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 04b4d8e 
> 
> Diff: https://reviews.apache.org/r/10137/diff/
> 
> 
> Testing
> -------
> 
> Tested with Vsphere 5.1, Hypervisor (ESXi) installed on a mac mini. Working with OSX 10.6 and 10.7.
> 
> 
> Thanks,
> 
> Clément Mondon
> 
>


Re: Review Request: OSX Support with vSphere5.1

Posted by Clément Mondon <cl...@inria.fr>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10137/#review18934
-----------------------------------------------------------

Ship it!


Ship It!

- Clément Mondon


On April 4, 2013, 1:28 p.m., Clément Mondon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10137/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 1:28 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Add OS X 10.6 and 10.7 support on VSphere 5.1 clusters (vSphere 5.1 officially support OSX Guests).
> 
> To run OS X guest instances, this patch defines several extra options passed to the vmx file : 
> - Emulate SMC device
> - Use EFI
> - root disk controller must be scsi
> 
> This patch modifies "VMwareGuru.java", previously modified by commit f7b600b43921ee2324e049432c9cf18906fc6772, to allow overwriting the global setting "vmware.root.disk.controller" when vmware.root.disk.controller is defined in the template definition. 
> 
> 
> This addresses bug CLOUDSTACK-1933.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java bb7c297 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 82a69bd 
>   setup/db/db/schema-410to420.sql 9eed0a6 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 04b4d8e 
> 
> Diff: https://reviews.apache.org/r/10137/diff/
> 
> 
> Testing
> -------
> 
> Tested with Vsphere 5.1, Hypervisor (ESXi) installed on a mac mini. Working with OSX 10.6 and 10.7.
> 
> 
> Thanks,
> 
> Clément Mondon
> 
>


Re: Review Request: OSX Support with vSphere5.1

Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10137/
-----------------------------------------------------------

(Updated April 4, 2013, 1:28 p.m.)


Review request for cloudstack and Kelven Yang.


Description
-------

Add OS X 10.6 and 10.7 support on VSphere 5.1 clusters (vSphere 5.1 officially support OSX Guests).

To run OS X guest instances, this patch defines several extra options passed to the vmx file : 
- Emulate SMC device
- Use EFI
- root disk controller must be scsi

This patch modifies "VMwareGuru.java", previously modified by commit f7b600b43921ee2324e049432c9cf18906fc6772, to allow overwriting the global setting "vmware.root.disk.controller" when vmware.root.disk.controller is defined in the template definition. 


This addresses bug CLOUDSTACK-1933.


Diffs
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java bb7c297 
  server/src/com/cloud/vm/UserVmManagerImpl.java 82a69bd 
  setup/db/db/schema-410to420.sql 9eed0a6 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 04b4d8e 

Diff: https://reviews.apache.org/r/10137/diff/


Testing
-------

Tested with Vsphere 5.1, Hypervisor (ESXi) installed on a mac mini. Working with OSX 10.6 and 10.7.


Thanks,

Clément Mondon