[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #25942: support pg bit and bool type parsed from/to java&jdbc

["TeslaCN (via GitHub)" <gi...@apache.org>]

TeslaCN commented on code in PR #25942:
URL: https://github.com/apache/shardingsphere/pull/25942#discussion_r1209646536


##########
proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/response/data/QueryResponseCell.java:
##########
@@ -18,16 +18,26 @@
 package org.apache.shardingsphere.proxy.backend.response.data;
 
 import lombok.Getter;
-import lombok.RequiredArgsConstructor;
 
 /**
  * Query response cell.
  */
-@RequiredArgsConstructor
 @Getter
 public final class QueryResponseCell {
     
     private final int jdbcType;
     
     private final Object data;
+    
+    private String columnTypeName;

Review Comment:
   If this field is nullable, is it possible to make it final and add an Optional getter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org