Re: [PR] Upgrade Log4j to `2.25.2` [solr]

["ppkarwasz (via GitHub)" <gi...@apache.org>]

ppkarwasz commented on code in PR #3603:
URL: https://github.com/apache/solr/pull/3603#discussion_r2372240762


##########
solr/modules/extraction/build.gradle:
##########
@@ -19,6 +19,13 @@ apply plugin: 'java-library'
 
 description = 'Solr Integration with Tika for extracting content from binary file formats such as Microsoft Word and Adobe PDF'
 
+configurations.configureEach {

Review Comment:
   Good catch! :100:
   
   I thought I had documented this properly, but I had accidentally copy-pasted an unrelated comment. I’ve fixed it in ff2e69bbba56635784f40a4c3b95b5bb2eadb076.
   
   In short:
   
   * This change is **necessary to avoid license-check failures**.
   * SpotBugs Annotations is LGPL-2.1, which is a category B license for the ASF.
   * It gets pulled into Solr because Log4j `2.25.x` declares it as a `compileOnlyApi` dependency.
   * In Log4j we exported it only to silence a harmless `-Xlint:classfile` warning that could otherwise failing user builds with `-Werror`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org