You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/07/17 22:47:58 UTC
Review Request 23659: Allowed the port mapping isolator to tolerate early
child process termination.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23659/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
Bugs: MESOS-1610
https://issues.apache.org/jira/browse/MESOS-1610
Repository: mesos-git
Description
-------
See summary and ticket. The 'isolate()' can fail at any point if the child process dies. The 'cleanup' should tolerate this and do best effort cleanup.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b
Diff: https://reviews.apache.org/r/23659/diff/
Testing
-------
make check
sudo make check
Thanks,
Jie Yu
Re: Review Request 23659: Allowed the port mapping isolator to tolerate
early child process termination.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23659/#review48055
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23659/#comment84314>
can we explain a little more why isolate could could fail? like the comments you had in the ticket?
s/need/needs/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23659/#comment84320>
s/cleanup/clean up/
- Chi Zhang
On July 17, 2014, 8:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23659/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 8:47 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-1610
> https://issues.apache.org/jira/browse/MESOS-1610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. The 'isolate()' can fail at any point if the child process dies. The 'cleanup' should tolerate this and do best effort cleanup.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b
>
> Diff: https://reviews.apache.org/r/23659/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 23659: Allowed the port mapping isolator to tolerate
early child process termination.
Posted by Jie Yu <yu...@gmail.com>.
> On July 17, 2014, 9:08 p.m., Chi Zhang wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2014
> > <https://reviews.apache.org/r/23659/diff/1/?file=634575#file634575line2014>
> >
> > not sure if this is a good place to use VLOG instead?
I still prefer a LOG(INFO) as this is not quite frequent and we need this in the log to decide if that function finishes successfully or not.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23659/#review48057
-----------------------------------------------------------
On July 17, 2014, 8:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23659/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 8:47 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-1610
> https://issues.apache.org/jira/browse/MESOS-1610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. The 'isolate()' can fail at any point if the child process dies. The 'cleanup' should tolerate this and do best effort cleanup.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b
>
> Diff: https://reviews.apache.org/r/23659/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 23659: Allowed the port mapping isolator to tolerate
early child process termination.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23659/#review48057
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23659/#comment84325>
not sure if this is a good place to use VLOG instead?
- Chi Zhang
On July 17, 2014, 8:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23659/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 8:47 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-1610
> https://issues.apache.org/jira/browse/MESOS-1610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. The 'isolate()' can fail at any point if the child process dies. The 'cleanup' should tolerate this and do best effort cleanup.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b
>
> Diff: https://reviews.apache.org/r/23659/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 23659: Allowed the port mapping isolator to tolerate
early child process termination.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23659/#review48066
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23659/#comment84340>
s/not/no/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23659/#comment84343>
s/in/at/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23659/#comment84346>
Suggest ", " would be a clearer delimiter since ":" is used within an error string?
- Ian Downes
On July 17, 2014, 1:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23659/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 1:47 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-1610
> https://issues.apache.org/jira/browse/MESOS-1610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. The 'isolate()' can fail at any point if the child process dies. The 'cleanup' should tolerate this and do best effort cleanup.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b
>
> Diff: https://reviews.apache.org/r/23659/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>