You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/04 19:01:30 UTC
[GitHub] [kafka] abbccdda opened a new pull request #9124: MINOR: add additional shutdown log info
abbccdda opened a new pull request #9124:
URL: https://github.com/apache/kafka/pull/9124
The purpose of this PR is to both enhance the visibility of shutdown progress for Kafka, as well as for the debugging purpose of a delayed process in between socket server close and eventually kafka server close.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda merged pull request #9124: MINOR: add additional shutdown log info
Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #9124:
URL: https://github.com/apache/kafka/pull/9124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #9124: MINOR: add additional shutdown log info
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #9124:
URL: https://github.com/apache/kafka/pull/9124#discussion_r465309685
##########
File path: clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
##########
@@ -673,6 +673,8 @@ public void close() {
log.error("Error when closing " + reporter.getClass().getName(), e);
}
}
+
+ log.info("Metrics closed");
Review comment:
Would it be reasonable to add a message before closing each individual reporter?
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -225,6 +225,7 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging
dynamicDefaultConfigs.clear()
reconfigurables.clear()
brokerReconfigurables.clear()
+ info(s"Dynamic configs cleared")
Review comment:
nit: this one is probably overkill since we're just clearing collections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org