You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/02 00:50:41 UTC
[GitHub] [maven-verifier] adekzs opened a new pull request, #55: Deprecate multivariant constructors for removal
adekzs opened a new pull request, #55:
URL: https://github.com/apache/maven-verifier/pull/55
The redundant constructors have been deprecated. The update is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski merged pull request #55: [MSHARED-1146] Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #55:
URL: https://github.com/apache/maven-verifier/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on pull request #55: Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#issuecomment-1264603453
Please look at build result, the same should be when you build project locally 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on pull request #55: [MSHARED-1146] Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#issuecomment-1265807749
@adekzs thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #55: Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#discussion_r985238080
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,61 +115,157 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
this( basedir, null, debug );
Review Comment:
I would to change body of constructors to show replacements, so should be:
```
this(basedir);
...
needed set methods
```
in all deprecated constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] adekzs commented on a diff in pull request #55: Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
adekzs commented on code in PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#discussion_r985238864
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,61 +115,157 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
this( basedir, null, debug );
Review Comment:
Okay, I get your point. I will update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #55: Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#discussion_r985248420
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
+ setDefaultCliArguments( defaultCliArguments );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String)},
+ * {@link #setSettingsFile(String)} to set settings file
+ * and {@link #setForkJvm(Boolean)} to set forkJvm status
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( forkJvm );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ *{@link #setSettingsFile(String settingsFile)} to set settings file,
+ *{@link #setForkJvm(Boolean)} to set forkJvm status and
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, defaultCliArguments, null );
+ this( basedir );
+ setSettingsFile( basedir );
+ setDebug( debug );
+ setForkJvm( forkJvm );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( null );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, DEFAULT_CLI_ARGUMENTS, mavenHome );
+ this( basedir );
+ setForkJvm( null );
Review Comment:
Is it needed?
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
+ setDefaultCliArguments( defaultCliArguments );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String)},
+ * {@link #setSettingsFile(String)} to set settings file
+ * and {@link #setForkJvm(Boolean)} to set forkJvm status
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( forkJvm );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ *{@link #setSettingsFile(String settingsFile)} to set settings file,
+ *{@link #setForkJvm(Boolean)} to set forkJvm status and
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, defaultCliArguments, null );
+ this( basedir );
+ setSettingsFile( basedir );
+ setDebug( debug );
+ setForkJvm( forkJvm );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( null );
Review Comment:
the same question...
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
Review Comment:
Is it needed with `null` ?
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
+ setDefaultCliArguments( defaultCliArguments );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String)},
+ * {@link #setSettingsFile(String)} to set settings file
+ * and {@link #setForkJvm(Boolean)} to set forkJvm status
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( forkJvm );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ *{@link #setSettingsFile(String settingsFile)} to set settings file,
+ *{@link #setForkJvm(Boolean)} to set forkJvm status and
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, defaultCliArguments, null );
+ this( basedir );
+ setSettingsFile( basedir );
+ setDebug( debug );
+ setForkJvm( forkJvm );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( null );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, DEFAULT_CLI_ARGUMENTS, mavenHome );
+ this( basedir );
+ setForkJvm( null );
+ setDebug( debug );
+ setSettingsFile( settingsFile );
+ setMavenHome( mavenHome );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ * use {@link #setMavenHome(String mavenHome)} to set maven home
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome,
String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments, mavenHome );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( null );
Review Comment:
?
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
+ setDefaultCliArguments( defaultCliArguments );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String)},
+ * {@link #setSettingsFile(String)} to set settings file
+ * and {@link #setForkJvm(Boolean)} to set forkJvm status
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( forkJvm );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ *{@link #setSettingsFile(String settingsFile)} to set settings file,
+ *{@link #setForkJvm(Boolean)} to set forkJvm status and
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, defaultCliArguments, null );
+ this( basedir );
+ setSettingsFile( basedir );
+ setDebug( debug );
+ setForkJvm( forkJvm );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( null );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, DEFAULT_CLI_ARGUMENTS, mavenHome );
+ this( basedir );
+ setForkJvm( null );
+ setDebug( debug );
+ setSettingsFile( settingsFile );
+ setMavenHome( mavenHome );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ * use {@link #setMavenHome(String mavenHome)} to set maven home
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome,
String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments, mavenHome );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( null );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( mavenHome );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ * use {@link #setForkJvm(Boolean)} to set forkJvm status
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set CLI Arguments
+ * use {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
private Verifier( String basedir, String settingsFile, boolean debug, Boolean forkJvm, String[] defaultCliArguments,
String mavenHome ) throws VerificationException
{
Review Comment:
Is it still used?
If no we can remove private constructor at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-verifier] adekzs commented on a diff in pull request #55: Deprecate multivariant constructors for removal
Posted by GitBox <gi...@apache.org>.
adekzs commented on code in PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#discussion_r985251218
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
+ setDefaultCliArguments( defaultCliArguments );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String)},
+ * {@link #setSettingsFile(String)} to set settings file
+ * and {@link #setForkJvm(Boolean)} to set forkJvm status
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( forkJvm );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ *{@link #setSettingsFile(String settingsFile)} to set settings file,
+ *{@link #setForkJvm(Boolean)} to set forkJvm status and
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, defaultCliArguments, null );
+ this( basedir );
+ setSettingsFile( basedir );
+ setDebug( debug );
+ setForkJvm( forkJvm );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( null );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, DEFAULT_CLI_ARGUMENTS, mavenHome );
+ this( basedir );
+ setForkJvm( null );
+ setDebug( debug );
+ setSettingsFile( settingsFile );
+ setMavenHome( mavenHome );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ * use {@link #setMavenHome(String mavenHome)} to set maven home
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome,
String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments, mavenHome );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( null );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( mavenHome );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ * use {@link #setForkJvm(Boolean)} to set forkJvm status
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set CLI Arguments
+ * use {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
private Verifier( String basedir, String settingsFile, boolean debug, Boolean forkJvm, String[] defaultCliArguments,
String mavenHome ) throws VerificationException
{
Review Comment:
It is no longer in use, I will remove this.
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,87 +115,195 @@
private static MavenLauncher embeddedLauncher;
+ private String settingsFile;
+
+ private boolean debug;
+
public Verifier( String basedir )
throws VerificationException
{
- this( basedir, null );
+ this.basedir = basedir;
+
+ this.forkMode = System.getProperty( "verifier.forkMode" );
+
+ findLocalRepo( settingsFile );
+
+ this.mavenHome = System.getProperty( "maven.home" );
+
+ useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+ this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, boolean debug )
throws VerificationException
{
- this( basedir, null, debug );
+ this( basedir );
+ setDebug( debug );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile )
throws VerificationException
{
- this( basedir, settingsFile, false );
+ this( basedir );
+ setSettingsFile( settingsFile );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * and {@link #setSettingsFile(String settingsFile)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug )
throws VerificationException
{
- this( basedir, settingsFile, debug, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set default cliArguments
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setMavenHome( null );
+ setDefaultCliArguments( defaultCliArguments );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String)},
+ * {@link #setSettingsFile(String)} to set settings file
+ * and {@link #setForkJvm(Boolean)} to set forkJvm status
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, DEFAULT_CLI_ARGUMENTS );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( forkJvm );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ *{@link #setSettingsFile(String settingsFile)} to set settings file,
+ *{@link #setForkJvm(Boolean)} to set forkJvm status and
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, boolean forkJvm, String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, forkJvm, defaultCliArguments, null );
+ this( basedir );
+ setSettingsFile( basedir );
+ setDebug( debug );
+ setForkJvm( forkJvm );
+ setDefaultCliArguments( defaultCliArguments );
+ setMavenHome( null );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)},
+ * {@link #setSettingsFile(String settingsFile)} to set settings file
+ * and {@link #setMavenHome(String mavenHome)} to set maven home
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, DEFAULT_CLI_ARGUMENTS, mavenHome );
+ this( basedir );
+ setForkJvm( null );
+ setDebug( debug );
+ setSettingsFile( settingsFile );
+ setMavenHome( mavenHome );
}
+ /**
+ *
+ * @deprecated to be removed
+ * use {@link #Verifier(String basedir)}
+ * use {@link #setSettingsFile(String settingsFile)} to set settings file
+ * use {@link #setMavenHome(String mavenHome)} to set maven home
+ * use {@link #setDefaultCliArguments(String[] defaultCliArguments)} to set settings file
+ *
+ * */
+ @Deprecated
public Verifier( String basedir, String settingsFile, boolean debug, String mavenHome,
String[] defaultCliArguments )
throws VerificationException
{
- this( basedir, settingsFile, debug, null, defaultCliArguments, mavenHome );
+ this( basedir );
+ setSettingsFile( settingsFile );
+ setDebug( debug );
+ setForkJvm( null );
Review Comment:
setting null for ForkJvm is also unnecessary, I will remove this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org