[GitHub] [pulsar] Jason918 commented on a diff in pull request #16336: [improve][java-client] Improve performance of multi-topic consumer with more than one IO thread

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #16336:
URL: https://github.com/apache/pulsar/pull/16336#discussion_r912334908


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##########
@@ -1045,6 +1054,12 @@ private void doSubscribeTopicPartitions(Schema<T> schema,
                         String partitionName = TopicName.get(topicName).getPartition(partitionIndex).toString();
                         CompletableFuture<Consumer<T>> subFuture = new CompletableFuture<>();
                         configurationData.setStartPaused(paused);
+                        BatchReceivePolicy internalBatchReceivePolicy = BatchReceivePolicy.builder()
+                                .maxNumMessages(Math.max(receiverQueueSize / 2, 1))
+                                .maxNumBytes(-1)
+                                .timeout(0, TimeUnit.MILLISECONDS)
+                                .build();
+                        configurationData.setBatchReceivePolicy(internalBatchReceivePolicy);

Review Comment:
   There are other 2 places creating `ConsumerImpl` in this class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org