You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/12 18:01:51 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4376:
Config for overriding initial rows threshold in segment size auto tuning
codecov-io edited a comment on issue #4376: Config for overriding initial rows threshold in segment size auto tuning
URL: https://github.com/apache/incubator-pinot/pull/4376#issuecomment-506562782
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=h1) Report
> Merging [#4376](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/89a344998bce7aeaeda8a4a49d5df175bdb82185?src=pr&el=desc) will **increase** coverage by `0.2%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4376 +/- ##
==========================================
+ Coverage 65.29% 65.5% +0.2%
Complexity 20 20
==========================================
Files 1065 1075 +10
Lines 55245 55851 +606
Branches 7859 7968 +109
==========================================
+ Hits 36073 36585 +512
- Misses 16625 16643 +18
- Partials 2547 2623 +76
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/core/realtime/stream/StreamConfigProperties.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vU3RyZWFtQ29uZmlnUHJvcGVydGllcy5qYXZh) | `66.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../realtime/segment/FlushThresholdUpdateManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvRmx1c2hUaHJlc2hvbGRVcGRhdGVNYW5hZ2VyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...segment/SegmentSizeBasedFlushThresholdUpdater.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvU2VnbWVudFNpemVCYXNlZEZsdXNoVGhyZXNob2xkVXBkYXRlci5qYXZh) | `70.76% <100%> (+0.45%)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/core/realtime/stream/StreamConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vU3RyZWFtQ29uZmlnLmphdmE=) | `97.53% <83.33%> (-1.8%)` | `0 <0> (ø)` | |
| [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...pinot/pql/parsers/pql2/ast/InPredicateAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9JblByZWRpY2F0ZUFzdE5vZGUuamF2YQ==) | `42.46% <0%> (-26.03%)` | `0% <0%> (ø)` | |
| [...ers/pql2/ast/PredicateParenthesisGroupAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVQYXJlbnRoZXNpc0dyb3VwQXN0Tm9kZS5qYXZh) | `75% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...ot/controller/helix/core/util/ZKMetadataUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvWktNZXRhZGF0YVV0aWxzLmphdmE=) | `68.96% <0%> (-24.14%)` | `0% <0%> (ø)` | |
| [...not/pql/parsers/pql2/ast/PredicateListAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVMaXN0QXN0Tm9kZS5qYXZh) | `76.74% <0%> (-16.28%)` | `0% <0%> (ø)` | |
| [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `85.33% <0%> (-7.9%)` | `0% <0%> (ø)` | |
| ... and [89 more](https://codecov.io/gh/apache/incubator-pinot/pull/4376/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=footer). Last update [89a3449...2fac914](https://codecov.io/gh/apache/incubator-pinot/pull/4376?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org