You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/07 02:36:04 UTC
Review Request 68250: Pass compiler/linker flags when building the
gRPC bundle in Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68250/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and James Peach.
Bugs: MESOS-9137
https://issues.apache.org/jira/browse/MESOS-9137
Repository: mesos
Description
-------
Since gRPC does not use Autotools, we have to manually pass compiler and
linker flags when issuing `make` to make the build flags consistent with
the Mesos build that initiate the gRPC bundle build.
With this fix, Mesos can be configured as follows to enable thread
sanitizer:
CFLAGS='-fsanitize=thread'
CXXFLAGS='-fsanitize=thread'
LDFLAGS='-fsanitize=thread'
Diffs
-----
3rdparty/Makefile.am 6476b043090b24e8a70982a887b21096752b5581
Diff: https://reviews.apache.org/r/68250/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 68250: Pass compiler/linker flags when building
the gRPC bundle in Mesos.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68250/#review206950
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 7, 2018, 2:36 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68250/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 2:36 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Bugs: MESOS-9137
> https://issues.apache.org/jira/browse/MESOS-9137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC does not use Autotools, we have to manually pass compiler and
> linker flags when issuing `make` to make the build flags consistent with
> the Mesos build that initiate the gRPC bundle build.
>
> With this fix, Mesos can be configured as follows to enable thread
> sanitizer:
> CFLAGS='-fsanitize=thread'
> CXXFLAGS='-fsanitize=thread'
> LDFLAGS='-fsanitize=thread'
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 6476b043090b24e8a70982a887b21096752b5581
>
>
> Diff: https://reviews.apache.org/r/68250/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>