You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Jan Arend Jansen (JIRA)" <ji...@apache.org> on 2008/01/04 16:59:43 UTC

[jira] Created: (SM-1189) Race condintion in Auto Deployer

Race condintion in Auto Deployer
--------------------------------

                 Key: SM-1189
                 URL: https://issues.apache.org/activemq/browse/SM-1189
             Project: ServiceMix
          Issue Type: Bug
          Components: servicemix-core
    Affects Versions: 3.2.1
         Environment: Windows Vista x64
            Reporter: Jan Arend Jansen
            Priority: Minor
         Attachments: patch.diff

Copying an SA into the hotdeploy folder can lead to a race condition. If the copy takes too long, the deployer will fail with a FileNotFoundException.

I've attached a possible fix for this (not tested)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1189) Race condintion in Auto Deployer

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41361#action_41361 ] 

Guillaume Nodet commented on SM-1189:
-------------------------------------

Have you been able to test your patch ?
I'm not sure it will really help.

I would think a better fix would be to wait 100 ms and see if the file size has changed or not.
If not, we can assume that the file has been completely written.

> Race condintion in Auto Deployer
> --------------------------------
>
>                 Key: SM-1189
>                 URL: https://issues.apache.org/activemq/browse/SM-1189
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.2.1
>         Environment: Windows Vista x64
>            Reporter: Jan Arend Jansen
>            Priority: Minor
>         Attachments: patch.diff
>
>
> Copying an SA into the hotdeploy folder can lead to a race condition. If the copy takes too long, the deployer will fail with a FileNotFoundException.
> I've attached a possible fix for this (not tested)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1189) Race condintion in Auto Deployer

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41364#action_41364 ] 

Chris Custine commented on SM-1189:
-----------------------------------

I fixed this issue last week but I didn't see this duplicate issue.  The fix implemented checks the file size and also attempts to open the zip file.

> Race condintion in Auto Deployer
> --------------------------------
>
>                 Key: SM-1189
>                 URL: https://issues.apache.org/activemq/browse/SM-1189
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.2.1
>         Environment: Windows Vista x64
>            Reporter: Jan Arend Jansen
>            Assignee: Chris Custine
>            Priority: Minor
>             Fix For: 3.2.2, 3.3
>
>         Attachments: patch.diff
>
>
> Copying an SA into the hotdeploy folder can lead to a race condition. If the copy takes too long, the deployer will fail with a FileNotFoundException.
> I've attached a possible fix for this (not tested)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SM-1189) Race condintion in Auto Deployer

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine resolved SM-1189.
-------------------------------

         Assignee: Chris Custine
    Fix Version/s: 3.2.2
                   3.3
       Resolution: Fixed

> Race condintion in Auto Deployer
> --------------------------------
>
>                 Key: SM-1189
>                 URL: https://issues.apache.org/activemq/browse/SM-1189
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.2.1
>         Environment: Windows Vista x64
>            Reporter: Jan Arend Jansen
>            Assignee: Chris Custine
>            Priority: Minor
>             Fix For: 3.2.2, 3.3
>
>         Attachments: patch.diff
>
>
> Copying an SA into the hotdeploy folder can lead to a race condition. If the copy takes too long, the deployer will fail with a FileNotFoundException.
> I've attached a possible fix for this (not tested)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.