You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/08/31 07:39:33 UTC

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #293: OAK-9436 clean transient session storage after exceptions during import

thomasmueller commented on a change in pull request #293:
URL: https://github.com/apache/jackrabbit-oak/pull/293#discussion_r699065068



##########
File path: oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/xml/ImporterImpl.java
##########
@@ -336,138 +339,150 @@ public void startNode(@NotNull NodeInfo nodeInfo, @NotNull List<PropInfo> propIn
             throws RepositoryException {
         Tree parent = parents.peek();
         Tree tree = null;
-        String id = nodeInfo.getUUID();

Review comment:
       What I sometimes do in such cases (to simplify the diff) is create a new method, e.g. getPropertyImportersTry, and then call it in a try-catch.
   
   But I don't know this area so I'm afraid I'm not the right person to review...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org