You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "style95 (via GitHub)" <gi...@apache.org> on 2023/05/30 22:33:09 UTC
[GitHub] [openwhisk] style95 opened a new pull request, #5419: Finish setup on error
style95 opened a new pull request, #5419:
URL: https://github.com/apache/openwhisk/pull/5419
<!--- Provide a concise summary of your changes in the Title -->
## Description
This is to fast fail on any error.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [x] I opened an issue to propose and discuss this change (#5417)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [x] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #5419: Finish setup on error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5419:
URL: https://github.com/apache/openwhisk/pull/5419#issuecomment-1569269250
## [Codecov](https://app.codecov.io/gh/apache/openwhisk/pull/5419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5419](https://app.codecov.io/gh/apache/openwhisk/pull/5419?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (33958a4) into [master](https://app.codecov.io/gh/apache/openwhisk/commit/6c47e6024d9de18c7151e4f04f56a195e98b0cd3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6c47e60) will **increase** coverage by `0.03%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 33958a4 differs from pull request most recent head 740e265. Consider uploading reports for the commit 740e265 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5419 +/- ##
==========================================
+ Coverage 76.63% 76.67% +0.03%
==========================================
Files 241 241
Lines 14630 14630
Branches 616 616
==========================================
+ Hits 11212 11217 +5
+ Misses 3418 3413 -5
```
| [Impacted Files](https://app.codecov.io/gh/apache/openwhisk/pull/5419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/openwhisk/core/scheduler/Scheduler.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvU2NoZWR1bGVyLnNjYWxh) | `10.75% <0.00%> (ø)` | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/openwhisk/pull/5419/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on a diff in pull request #5419: Finish setup on error
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on code in PR #5419:
URL: https://github.com/apache/openwhisk/pull/5419#discussion_r1210889107
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala:
##########
@@ -221,8 +221,7 @@ class Scheduler(schedulerId: SchedulerInstanceId, schedulerEndpoints: SchedulerE
}
val topic = s"${Scheduler.topicPrefix}scheduler${schedulerId.asString}"
- val schedulerConsumer =
- msgProvider.getConsumer(config, topic, topic, maxPeek, maxPollInterval = TimeLimit.MAX_DURATION + 1.minute)
+ val schedulerConsumer = msgProvider.getConsumer(config, topic, topic, maxPeek, maxPollInterval = TimeLimit.MAX_DURATION + 1.minute)
Review Comment:
It is wrongly formatted for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on a diff in pull request #5419: Finish setup on error
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on code in PR #5419:
URL: https://github.com/apache/openwhisk/pull/5419#discussion_r1210910164
##########
tools/github/setup.sh:
##########
@@ -20,6 +20,8 @@
#then echo skipping setup ; exit 0
#fi
+set -e
Review Comment:
It is required to finish on an error.
Now it works as expected.
<img width="1329" alt="image" src="https://github.com/apache/openwhisk/assets/3447251/a3db7a6b-bf1c-4577-ab72-4bfb2fea45a3">
I will revert the temporary commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 merged pull request #5419: Finish setup on error
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 merged PR #5419:
URL: https://github.com/apache/openwhisk/pull/5419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5419: Finish setup on error
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #5419:
URL: https://github.com/apache/openwhisk/pull/5419#issuecomment-1569220588
It's strange that CI does not start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org