You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/03/31 11:40:13 UTC
[GitHub] [iceberg] Fokko commented on a diff in pull request #7248: Python: Use Prettier to format TOML and more files
Fokko commented on code in PR #7248:
URL: https://github.com/apache/iceberg/pull/7248#discussion_r1154367480
##########
python/mkdocs/docs/api.md:
##########
@@ -307,15 +307,18 @@ scan = table.scan(
The low level API `plan_files` methods returns a set of tasks that provide the files that might contain matching rows:
```json
-['s3a://warehouse/wh/nyc/taxis/data/00003-4-42464649-92dd-41ad-b83b-dea1a2fe4b58-00001.parquet']
+[
+ "s3a://warehouse/wh/nyc/taxis/data/00003-4-42464649-92dd-41ad-b83b-dea1a2fe4b58-00001.parquet"
+]
```
In this case it is up to the engine itself to filter the file itself. Below, `to_arrow()` and `to_duckdb()` that already do this for you.
### Apache Arrow
!!! note "Requirements"
- This requires [PyArrow to be installed](index.md)
+
+This requires [PyArrow to be installed](index.md)
Review Comment:
This breaks the note unfortunately.
##########
python/mkdocs/docs/feature-support.md:
##########
@@ -21,21 +21,21 @@ The goal is that the python library will provide a functional, performant subset
## Metadata
-| Operation | Java | Python |
-|:-------------------------|:-----:|:------:|
-| Get Schema | X | X |
-| Get Snapshots | X | X |
-| Plan Scan | X | X |
-| Plan Scan for Snapshot | X | X |
-| Update Current Snapshot | X | |
-| Create Table | X | X |
-| Rename Table | X | X |
-| Drop Table | X | X |
-| Alter Table | X | |
-| Set Table Properties | X | |
-| Create Namespace | X | X |
-| Drop Namespace | X | X |
-| Set Namespace Properties | X | X |
+| Operation | Java | Python |
Review Comment:
I checked and this looks good:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org