You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/09 09:46:00 UTC
[GitHub] [commons-lang] mmariotti opened a new pull request, #967: add StringUtils.ubstringBeforeLast(String, int)
mmariotti opened a new pull request, #967:
URL: https://github.com/apache/commons-lang/pull/967
Hello,
This method with int param is missing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #967: add StringUtils.substringBeforeLast(String, int)
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on PR #967:
URL: https://github.com/apache/commons-lang/pull/967#issuecomment-1278136580
HI @mmariotti
Thank you for your PR. Can you add test cases that cover all the possible path?
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #967: add StringUtils.substringBeforeLast(String, int)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #967:
URL: https://github.com/apache/commons-lang/pull/967#issuecomment-1272508474
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#967](https://codecov.io/gh/apache/commons-lang/pull/967?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (731f99b) into [master](https://codecov.io/gh/apache/commons-lang/commit/ff733d9d9bb03ce840200aa213b7bdfc5755777d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff733d9) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #967 +/- ##
============================================
- Coverage 91.99% 91.96% -0.03%
- Complexity 7432 7433 +1
============================================
Files 189 189
Lines 15664 15670 +6
Branches 2907 2908 +1
============================================
+ Hits 14410 14411 +1
- Misses 677 683 +6
+ Partials 577 576 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/967?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ain/java/org/apache/commons/lang3/StringUtils.java](https://codecov.io/gh/apache/commons-lang/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nVXRpbHMuamF2YQ==) | `98.45% <0.00%> (-0.36%)` | :arrow_down: |
| [...apache/commons/lang3/reflect/ConstructorUtils.java](https://codecov.io/gh/apache/commons-lang/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvcmVmbGVjdC9Db25zdHJ1Y3RvclV0aWxzLmphdmE=) | `86.00% <0.00%> (+2.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org