You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 02:30:25 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request, #5999: fs/sync: add sync and syncfs api
Donny9 opened a new pull request, #5999:
URL: https://github.com/apache/incubator-nuttx/pull/5999
## Summary
sync: add sync and syncfs api
Signed-off-by: Jiuzhu Dong <do...@xiaomi.com>
## Impact
support sync and syncfs
## Testing
Ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#issuecomment-1404486008
No, sync isn't implemented yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #5999: fs/sync: add sync api
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #5999:
URL: https://github.com/apache/nuttx/pull/5999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #5999: fs/sync: add sync and syncfs api
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#discussion_r1098139509
##########
syscall/syscall.csv:
##########
@@ -165,6 +165,7 @@
"socketpair","sys/socket.h","defined(CONFIG_NET)","int","int","int","int","int [2]|FAR int *"
"stat","sys/stat.h","","int","FAR const char *","FAR struct stat *"
"statfs","sys/statfs.h","","int","FAR const char *","FAR struct statfs *"
+"sync","unistd.h","","void"
Review Comment:
move after line 169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #5999: fs/sync: add sync and syncfs api
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#discussion_r1083240025
##########
libs/libc/unistd/lib_sync.c:
##########
@@ -0,0 +1,85 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_sync.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Type Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: sync
+ *
+ * Description:
+ * sync() causes all pending modifications to filesystem metadata and
+ * cached file data to be written to the underlying filesystems.
+ *
+ * Returned Value:
+ * sync() is always successful.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+void sync(void)
+{
+}
+
+/****************************************************************************
+ * Name: syncfs
+ *
+ * Description:
+ * syncfs() is like sync(), but synchronizes just the filesystem
+ * containing file referred to by the open file descriptor fd.
+ *
+ * Returned Value:
+ * syncfs() returns 0 on success; on error, it returns -1 and sets
+ * errno to indicate the error.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+int syncfs(int fd)
+{
+ return 0;
Review Comment:
Here is the patch: https://github.com/apache/nuttx/pull/8092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by GitBox <gi...@apache.org>.
Donny9 commented on PR #5999:
URL: https://github.com/apache/incubator-nuttx/pull/5999#issuecomment-1091704189
>
There is currently no good idea to implement them, so assume they will always succeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#issuecomment-1404285391
@xiaoxiang781216 @Donny9 can we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #5999:
URL: https://github.com/apache/incubator-nuttx/pull/5999#issuecomment-1091360433
If there are no plans to implement then both could be handled as an empty defines at application layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by GitBox <gi...@apache.org>.
Donny9 commented on PR #5999:
URL: https://github.com/apache/incubator-nuttx/pull/5999#issuecomment-1091696859
> do you have a plan to actually implement them?
No, add them for iozone tools only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Donny9 commented on a diff in pull request #5999: fs/sync: add sync api
Posted by "Donny9 (via GitHub)" <gi...@apache.org>.
Donny9 commented on code in PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#discussion_r1098141193
##########
syscall/syscall.csv:
##########
@@ -165,6 +165,7 @@
"socketpair","sys/socket.h","defined(CONFIG_NET)","int","int","int","int","int [2]|FAR int *"
"stat","sys/stat.h","","int","FAR const char *","FAR struct stat *"
"statfs","sys/statfs.h","","int","FAR const char *","FAR struct statfs *"
+"sync","unistd.h","","void"
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #5999:
URL: https://github.com/apache/incubator-nuttx/pull/5999#issuecomment-1091718544
Then maybe it is more easy to handle this at iozone tools integration level only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5999: fs/sync: add sync and syncfs api
Posted by GitBox <gi...@apache.org>.
yamt commented on PR #5999:
URL: https://github.com/apache/incubator-nuttx/pull/5999#issuecomment-1091233567
do you have a plan to actually implement them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #5999: fs/sync: add sync and syncfs api
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#discussion_r1066247349
##########
libs/libc/unistd/lib_sync.c:
##########
@@ -0,0 +1,85 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_sync.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Type Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: sync
+ *
+ * Description:
+ * sync() causes all pending modifications to filesystem metadata and
+ * cached file data to be written to the underlying filesystems.
+ *
+ * Returned Value:
+ * sync() is always successful.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+void sync(void)
+{
+}
+
+/****************************************************************************
+ * Name: syncfs
+ *
+ * Description:
+ * syncfs() is like sync(), but synchronizes just the filesystem
+ * containing file referred to by the open file descriptor fd.
+ *
+ * Returned Value:
+ * syncfs() returns 0 on success; on error, it returns -1 and sets
+ * errno to indicate the error.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+int syncfs(int fd)
+{
+ return 0;
Review Comment:
@Donny9 we can forward to fsync directly
##########
libs/libc/unistd/lib_sync.c:
##########
@@ -0,0 +1,85 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_sync.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Type Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: sync
+ *
+ * Description:
+ * sync() causes all pending modifications to filesystem metadata and
+ * cached file data to be written to the underlying filesystems.
+ *
+ * Returned Value:
+ * sync() is always successful.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+void sync(void)
+{
Review Comment:
maybe we can iterate through all process and then file table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #5999: fs/sync: add sync api
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#issuecomment-1420151479
> @xiaoxiang781216 @Donny9 can we close this PR?
@pkarashchenko sync is ready for review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org