You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by akatz <gi...@git.apache.org> on 2015/10/01 15:51:13 UTC
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
GitHub user akatz opened a pull request:
https://github.com/apache/spark/pull/8957
[SPARK-10889] [Streaming] Bump KCL to add MillisBehindLatest metric
I don't believe the API changed at all.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akatz/spark kcl-upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8957.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8957
----
commit 6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe
Author: Avrohom Katz <ia...@gmail.com>
Date: 2015-09-30T22:26:36Z
Bump KCL to add MillisBehindLatest metric
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-164526102
@akatz did you run the Kinesis-specific tests for this PR? It appears this change may have broken Kinesis Streaming in 1.5.2 - https://mail-archives.apache.org/mod_mbox/spark-user/201512.mbox/%3CCALD%2B6GMXKOR5%3DbGYQhezXbV_qaJsoi2Y2cSbaDETeefWbh84Qg%40mail.gmail.com%3E
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-144873214
[Test build #1836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1836/console) for PR 8957 at commit [`6abc571`](https://github.com/apache/spark/commit/6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-144731855
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-145090416
[Test build #1838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1838/console) for PR 8957 at commit [`6abc571`](https://github.com/apache/spark/commit/6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class HyperLogLogPlusPlus(child: Expression, relativeSD: Double = 0.05)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-144793663
Seems OK to me, but the usual question is simply, does it introduce any potential problems too? changes dependencies, incompatible behavior, etc? might skim the release notes and commits if you can to sanity check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-144824044
[Test build #1834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1834/console) for PR 8957 at commit [`6abc571`](https://github.com/apache/spark/commit/6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class HyperLogLogPlusPlus(child: Expression, relativeSD: Double = 0.05)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by akatz <gi...@git.apache.org>.
Github user akatz commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-145067434
I skimmed the changes, it doesn't seem like they changed the public record processing API at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-145051723
[Test build #1838 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1838/consoleFull) for PR 8957 at commit [`6abc571`](https://github.com/apache/spark/commit/6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-145327961
Merged to master / 1.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8957
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-144847256
[Test build #1836 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1836/consoleFull) for PR 8957 at commit [`6abc571`](https://github.com/apache/spark/commit/6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10889] [Streaming] Bump KCL to add Mill...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8957#issuecomment-144793932
[Test build #1834 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1834/consoleFull) for PR 8957 at commit [`6abc571`](https://github.com/apache/spark/commit/6abc571a1a1d0a06565a0ec9fefa7bcb1ce69cfe).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org