You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2013/11/24 23:23:57 UTC
svn commit: r1545093 - in
/httpcomponents/httpcore/trunk/httpcore-nio/src/main:
java-deprecated/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java
java/org/apache/http/impl/nio/codecs/ChunkDecoder.java
Author: sebb
Date: Sun Nov 24 22:23:57 2013
New Revision: 1545093
URL: http://svn.apache.org/r1545093
Log:
Inline variable and avoid hiding field of same name
Modified:
httpcomponents/httpcore/trunk/httpcore-nio/src/main/java-deprecated/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java
httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/ChunkDecoder.java
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java-deprecated/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java-deprecated/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java?rev=1545093&r1=1545092&r2=1545093&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java-deprecated/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java-deprecated/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java Sun Nov 24 22:23:57 2013
@@ -459,10 +459,9 @@ public class ThrottlingHttpClientHandler
connState.setWorkerRunning(true);
}
- final HttpEntity entity = request.getEntity();
final OutputStream outstream = new ContentOutputStream(
connState.getOutbuffer());
- entity.writeTo(outstream);
+ request.getEntity().writeTo(outstream);
outstream.flush();
outstream.close();
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/ChunkDecoder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/ChunkDecoder.java?rev=1545093&r1=1545092&r2=1545093&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/ChunkDecoder.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/ChunkDecoder.java Sun Nov 24 22:23:57 2013
@@ -142,9 +142,8 @@ public class ChunkDecoder extends Abstra
if (count > 0) {
this.footers = new Header[this.trailerBufs.size()];
for (int i = 0; i < this.trailerBufs.size(); i++) {
- final CharArrayBuffer buffer = this.trailerBufs.get(i);
try {
- this.footers[i] = new BufferedHeader(buffer);
+ this.footers[i] = new BufferedHeader(this.trailerBufs.get(i));
} catch (final ParseException ex) {
throw new IOException(ex.getMessage());
}
@@ -250,11 +249,11 @@ public class ChunkDecoder extends Abstra
@Override
public String toString() {
- final StringBuilder buffer = new StringBuilder();
- buffer.append("[chunk-coded; completed: ");
- buffer.append(this.completed);
- buffer.append("]");
- return buffer.toString();
+ final StringBuilder sb = new StringBuilder();
+ sb.append("[chunk-coded; completed: ");
+ sb.append(this.completed);
+ sb.append("]");
+ return sb.toString();
}
}