[jira] [Commented] (YUNIKORN-2320) Package-level logger triggers early log system initialization, preventing custom logging configuration

["Craig Condit (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804812#comment-17804812 ] 

Craig Condit commented on YUNIKORN-2320:
----------------------------------------

I would look at making rateLimitedLog lazy-init. That was a relatively recent addition to logging and probably needs a second look.

> Package-level logger triggers early log system initialization, preventing custom logging configuration
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YUNIKORN-2320
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2320
>             Project: Apache YuniKorn
>          Issue Type: Bug
>            Reporter: Ovidiu Feodorov
>            Priority: Minor
>         Attachments: Screenshot 2024-01-03 at 3.36.33 PM.png
>
>
> {{objects.rateLimitedLog}} is initialized during package initialization phase, triggering {{log.once}} before {{log.InitializeLogger()}} has a chance to apply custom logging configuration. As result, the logging system does not accept custom configuration.
> {{entrypoint.TestCustomLoggingConfiguration()}} demonstrates the problem.
> There are several way to address the problem:
> 1. Lazy initialize the package-level logging variable {{objects.rateLimitedLog.}}
> 2. (preferred) Remove the package-level variable and replace it with an Application instance-level variable, which is also lazily initialized.
> More details available here: [https://yunikornworkspace.slack.com/archives/CLNUW68MU/p1704322291697499]
> Call stack that demonstrates the problem attached.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org