You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2018/06/09 00:24:18 UTC
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10672
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
---
M be/src/exec/hdfs-scan-node-base.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/10672/1
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:34:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
(Testing) Verified that the correct node id is being logged
with this patch and --v=2.
Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Reviewed-on: http://gerrit.cloudera.org:8080/10672
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-scan-node-base.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Jun 2018 00:53:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 1:
Please quickly mention how you tested the change. (maybe you looked at the logs?)
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 18:47:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 20:59:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 2:
Updated the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 06:49:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10672
to look at the new patch set (#2).
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
(Testing) Verified that the correct node id is being logged
with this patch and --v=2.
Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
---
M be/src/exec/hdfs-scan-node-base.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/10672/2
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 17:35:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 )
Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2639/
--
To view, visit http://gerrit.cloudera.org:8080/10672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7
Gerrit-Change-Number: 10672
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 17:35:36 +0000
Gerrit-HasComments: No