[jira] [Commented] (NUTCH-2911) Add cleanup call in Fetcher.java

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451163#comment-17451163 ] 

ASF GitHub Bot commented on NUTCH-2911:
---------------------------------------

prakharchaube opened a new pull request #708:
URL: https://github.com/apache/nutch/pull/708


   Fix for [NUTCH-2911](https://issues.apache.org/jira/browse/NUTCH-2911)
   
   Changes made : Added a wrapper try-finally block for FetcherRun.run() and called cleanup()


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add cleanup call in Fetcher.java
> --------------------------------
>
>                 Key: NUTCH-2911
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2911
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>            Reporter: Prakhar Chaube
>            Priority: Minor
>              Labels: improvement
>
> Fetcher's inner class, FetcherRun overrides Hadoop Mapper's run().
> Even though Nutch's FetcherRun doesn't need an explicit call the Mapper's cleanup() (Which is a blank function), it would increase the readability and completeness of the run Method to do so.
> Ideally, every implementation of Mapper is supposed to do the following tasks:
> 1. Perform Setup
> 2.  Call map on the data set
> 3. Perform cleanups.
> Moreover, in case a custom Fetcher is written extending Fetcher.java cleanup could get easily missed out.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)