You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/14 20:37:01 UTC
[kudu-CR] tablet copy-test-base: fix a null ptr deref in TearDown
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13332
to review the following change.
Change subject: tablet_copy-test-base: fix a null ptr deref in TearDown
......................................................................
tablet_copy-test-base: fix a null ptr deref in TearDown
If the mini tablet server fails to start (i.e. because of clock
desynchronization), the test crashes in TearDown.
tablet_copy_client-test: /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/src/kudu/gutil/ref_counted.h:284: T *scoped_refptr<kudu::tablet::TabletReplica>::operator->() const [T = kudu::tablet::TabletReplica]: Assertion `ptr_ != __null' failed.
*** Aborted at 1557801930 (unix time) try "date -d @1557801930" if you are using GNU date ***
PC: @ 0x7fb2ab088c37 gsignal
*** SIGABRT (@0x3e800001be3) received by PID 7139 (TID 0x7fb2b84f0440) from PID 7139; stack trace: ***
@ 0x46d9bd __tsan::CallUserSignalHandler() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/thirdparty/src/llvm-6.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1908
@ 0x46e9ab rtl_sigaction() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/thirdparty/src/llvm-6.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1997
@ 0x7fb2b2ee2330 (unknown) at ??:0
@ 0x7fb2ab088c37 gsignal at ??:0
@ 0x7fb2ab08c028 abort at ??:0
@ 0x7fb2ab081bf6 (unknown) at ??:0
@ 0x7fb2ab081ca2 __assert_fail at ??:0
@ 0x4eb7f0 scoped_refptr<>::operator->() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/src/kudu/tablet/tablet_replica.h:245
@ 0x4ed463 kudu::tserver::TabletCopyTest::TearDown() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/src/kudu/tserver/tablet_copy-test-base.h:60
@ 0x7fb2b75e8300 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb2b75c7531 testing::Test::Run() at ??:0
@ 0x7fb2b75c875d testing::TestInfo::Run() at ??:0
@ 0x7fb2b75c9237 testing::TestCase::Run() at ??:0
@ 0x7fb2b75d560b testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7fb2b75e9270 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb2b75d4ef3 testing::UnitTest::Run() at ??:0
@ 0x7fb2b7a3b4fc RUN_ALL_TESTS() at ??:0
@ 0x7fb2b7a3aca7 main at ??:0
@ 0x7fb2ab073f45 __libc_start_main at ??:0
@ 0x44473b (unknown) at ??:?
Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
---
M src/kudu/tserver/tablet_copy-test-base.h
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13332/1
--
To view, visit http://gerrit.cloudera.org:8080/13332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
Gerrit-Change-Number: 13332
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] tablet copy-test-base: fix a null ptr deref in TearDown
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13332 )
Change subject: tablet_copy-test-base: fix a null ptr deref in TearDown
......................................................................
Patch Set 1: Verified+1
TestDiffScan is still flaky, overriding.
--
To view, visit http://gerrit.cloudera.org:8080/13332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
Gerrit-Change-Number: 13332
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 May 2019 21:00:22 +0000
Gerrit-HasComments: No
[kudu-CR] tablet copy-test-base: fix a null ptr deref in TearDown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13332 )
Change subject: tablet_copy-test-base: fix a null ptr deref in TearDown
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
Gerrit-Change-Number: 13332
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 May 2019 20:39:28 +0000
Gerrit-HasComments: No
[kudu-CR] tablet copy-test-base: fix a null ptr deref in TearDown
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13332 )
Change subject: tablet_copy-test-base: fix a null ptr deref in TearDown
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
Gerrit-Change-Number: 13332
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] tablet copy-test-base: fix a null ptr deref in TearDown
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13332 )
Change subject: tablet_copy-test-base: fix a null ptr deref in TearDown
......................................................................
tablet_copy-test-base: fix a null ptr deref in TearDown
If the mini tablet server fails to start (i.e. because of clock
desynchronization), the test crashes in TearDown.
tablet_copy_client-test: /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/src/kudu/gutil/ref_counted.h:284: T *scoped_refptr<kudu::tablet::TabletReplica>::operator->() const [T = kudu::tablet::TabletReplica]: Assertion `ptr_ != __null' failed.
*** Aborted at 1557801930 (unix time) try "date -d @1557801930" if you are using GNU date ***
PC: @ 0x7fb2ab088c37 gsignal
*** SIGABRT (@0x3e800001be3) received by PID 7139 (TID 0x7fb2b84f0440) from PID 7139; stack trace: ***
@ 0x46d9bd __tsan::CallUserSignalHandler() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/thirdparty/src/llvm-6.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1908
@ 0x46e9ab rtl_sigaction() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/thirdparty/src/llvm-6.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1997
@ 0x7fb2b2ee2330 (unknown) at ??:0
@ 0x7fb2ab088c37 gsignal at ??:0
@ 0x7fb2ab08c028 abort at ??:0
@ 0x7fb2ab081bf6 (unknown) at ??:0
@ 0x7fb2ab081ca2 __assert_fail at ??:0
@ 0x4eb7f0 scoped_refptr<>::operator->() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/src/kudu/tablet/tablet_replica.h:245
@ 0x4ed463 kudu::tserver::TabletCopyTest::TearDown() at /data0/jenkins/workspace/kudu-pre-commit-unittest-TSAN/src/kudu/tserver/tablet_copy-test-base.h:60
@ 0x7fb2b75e8300 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb2b75c7531 testing::Test::Run() at ??:0
@ 0x7fb2b75c875d testing::TestInfo::Run() at ??:0
@ 0x7fb2b75c9237 testing::TestCase::Run() at ??:0
@ 0x7fb2b75d560b testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7fb2b75e9270 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb2b75d4ef3 testing::UnitTest::Run() at ??:0
@ 0x7fb2b7a3b4fc RUN_ALL_TESTS() at ??:0
@ 0x7fb2b7a3aca7 main at ??:0
@ 0x7fb2ab073f45 __libc_start_main at ??:0
@ 0x44473b (unknown) at ??:?
Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
Reviewed-on: http://gerrit.cloudera.org:8080/13332
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tserver/tablet_copy-test-base.h
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9257d20cf9728dfa3a58710e2dfc75f628c2daa5
Gerrit-Change-Number: 13332
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>