You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "SingingBush (via GitHub)" <gi...@apache.org> on 2024/09/23 18:44:55 UTC
[PR] add GitHub action [xerces-j]
SingingBush opened a new pull request, #1:
URL: https://github.com/apache/xerces-j/pull/1
I'd like to contribute to xerces-java but I feel that having a clearly visible CI process should be the first step before any further changes are made. As it stand it seems that some build targets are currently broken. These can be addressed in future pull requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] add GitHub action [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #1:
URL: https://github.com/apache/xerces-j/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] add GitHub action [xerces-j]
Posted by "SingingBush (via GitHub)" <gi...@apache.org>.
SingingBush commented on PR #1:
URL: https://github.com/apache/xerces-j/pull/1#issuecomment-2993714662
> Why didn't this run automatically on this PR? Is there an extra step to configure it, or will it only run after this is checked into the repo.
It's run on the branch in my fork. It'll need merging first for builds to run within this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] add GitHub action [xerces-j]
Posted by "SingingBush (via GitHub)" <gi...@apache.org>.
SingingBush commented on PR #1:
URL: https://github.com/apache/xerces-j/pull/1#issuecomment-2438112880
@mukulga please review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] add GitHub action [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #1:
URL: https://github.com/apache/xerces-j/pull/1#discussion_r2160009824
##########
.github/workflows/ant.yml:
##########
@@ -0,0 +1,67 @@
+name: Java CI
+
+on:
+ push:
+ branches: [main]
+ paths-ignore:
+ - '**.md'
+ pull_request:
+ branches: [main]
+ types:
+ - opened
+ - reopened
+ - synchronize
+ paths-ignore:
+ - '**.md'
+ workflow_dispatch:
+
+jobs:
+ build:
+ name: Build with Java ${{ matrix.jdk }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: ['8', '11', '17', '21']
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'temurin'
+ java-version: ${{ matrix.jdk }}
+
+ # use Ant directly to ensure targets work as expected
+ - name: Ant Build (target jars)
+ run: ant -noinput -buildfile build.xml jars
+
+ - name: Ant Build (target dtdjars)
+ run: ant -noinput -buildfile build.xml dtdjars
+
+ # test fails on JDK 8 due to java.lang.NoSuchFieldError
Review Comment:
I suspect we need to fix this ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org