[GitHub] [tvm] tiandiao123 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

[GitBox <gi...@apache.org>]

tiandiao123 commented on a change in pull request #8808:
URL: https://github.com/apache/tvm/pull/8808#discussion_r703967874



##########
File path: tests/python/contrib/test_tensorrt_int8_exp.py
##########
@@ -0,0 +1,129 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# FP16 TRT command to run : TVM_TENSORRT_USE_FP16=1 python test_trt.py
+# INT8 TRT command to run : TVM_TENSORRT_USE_INT8=1 TENSORRT_NUM_CALI_INT8=10 python test_trt.py

Review comment:
       > Thanks! @tiandiao123
   > Let's follow the format like other UTs to use:
   > 
   > ```python
   > def test_xxxxx():
   >     # You can use `os.environ["TVM_TENSORRT_USE_INT8"]=1` to set environment variable here
   >     # your test code here
   > 
   > if __name__ == "__main__":
   >     pytest.main([__file__])
   > ```
   > 
   > or this test cannot be processed by the CI automatically, see `tvm/tests/python/contrib/test_tensorrt.py` for reference.
   > 
   > Once we pass the CI, this PR will be ready to merge.
   
   Ok, I will fix it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org