You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@calcite.apache.org by Benoy Antony <ba...@gmail.com> on 2014/09/22 05:25:54 UTC

OPTIQ-282

Hi All,

I have generated a pull request for OPTIQ-282 at
https://github.com/apache/incubator-optiq/pull/13
  Could I please get a review of the patch ?


thanks ,
Benoy

Re: OPTIQ-282

Posted by Julian Hyde <ju...@gmail.com>.

Benoy,

Your patch looks basically good. I discovered a couple of issues, and noted them at https://github.com/apache/incubator-optiq/pull/13. When you address these, I will commit.

Julian

On Sep 21, 2014, at 9:00 PM, Julian Hyde <ju...@gmail.com> wrote:

> Yes, I will review.
> 
> By the way, great to see you at the hackathon. Good to see the finished
> work coming in!
> 
> Julian
> 
> On Sun, Sep 21, 2014 at 8:25 PM, Benoy Antony <ba...@gmail.com> wrote:
> 
>> Hi All,
>> 
>> I have generated a pull request for OPTIQ-282 at
>> https://github.com/apache/incubator-optiq/pull/13
>>  Could I please get a review of the patch ?
>> 
>> 
>> thanks ,
>> Benoy
>>

Re: OPTIQ-282

Posted by Julian Hyde <ju...@gmail.com>.

Yes, I will review.

By the way, great to see you at the hackathon. Good to see the finished
work coming in!

Julian

On Sun, Sep 21, 2014 at 8:25 PM, Benoy Antony <ba...@gmail.com> wrote:

> Hi All,
>
> I have generated a pull request for OPTIQ-282 at
> https://github.com/apache/incubator-optiq/pull/13
>   Could I please get a review of the patch ?
>
>
> thanks ,
> Benoy
>