[jira] [Work logged] (DAEMON-399) apxStrUnQuoteInplaceA removes needed quotes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DAEMON-399?focusedWorklogId=226699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226699 ]

ASF GitHub Bot logged work on DAEMON-399:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/19 14:45
            Start Date: 12/Apr/19 14:45
    Worklog Time Spent: 10m 
      Work Description: spjoe commented on pull request #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes
URL: https://github.com/apache/commons-daemon/pull/9
 
 
   For some JVM options quotes are needed even if no space is within the option.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 226699)
            Time Spent: 10m
    Remaining Estimate: 0h

> apxStrUnQuoteInplaceA removes needed quotes
> -------------------------------------------
>
>                 Key: DAEMON-399
>                 URL: https://issues.apache.org/jira/browse/DAEMON-399
>             Project: Commons Daemon
>          Issue Type: Bug
>          Components: Procrun
>    Affects Versions: 1.1.0
>            Reporter: Camillo Dell'mour
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When trying to pass the following argument to the jvm
> {code:java}
> -Xlog:gc:file="d:\logs\gc.log"::filecount=5,filesize=20000
> {code}
> the method apxStrUnQuoteInplaceA removes " from it and the resulting command looks like this:
> {code:java}
> -Xlog:gc:file=d:\logs\gc.log::filecount=5,filesize=2000
> {code}
> Which is an invalid jvm argument.
> Workaround for version 1.1.0 is to add a space into the log filename.
> IMHO the proper fix would be not too use apxStrUnQuoteInplaceA at all.
> Another possible fix would be to replace utils.c:571 with
> {code}
> else if (*p == ' ' || *p == ':') {
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)