You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pionCham (via GitHub)" <gi...@apache.org> on 2024/11/13 02:23:03 UTC

[PR] [BUILD] Bump maven plugin download version to 1.11.2 [kyuubi]

pionCham opened a new pull request, #6807:
URL: https://github.com/apache/kyuubi/pull/6807

   # :mag: Description
   ## Issue References 🔗
   <!-- Append the issue number after #. If there is no issue for you to link create one or -->
   <!-- If there are no issues to link, please provide details here. -->
   
   
   ## Describe Your Solution 🔧
   
   Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
   
   
   ## Types of changes :bookmark:
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   
   ## Test Plan 🧪
   
   #### Behavior Without This Pull Request :coffin:
   
   
   #### Behavior With This Pull Request :tada:
   
   
   #### Related Unit Tests
   
   
   ---
   
   # Checklist 📝
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   
   - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
   
   **Be nice. Be informative.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [BUILD] Bump maven download plugin from 1.8.1 to 1.11.3 [kyuubi]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #6807: [BUILD] Bump maven download plugin from 1.8.1 to 1.11.3
URL: https://github.com/apache/kyuubi/pull/6807


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [BUILD] Bump maven download plugin from 1.8.1 to 1.11.3 [kyuubi]

Posted by "pionCham (via GitHub)" <gi...@apache.org>.
pionCham commented on PR #6807:
URL: https://github.com/apache/kyuubi/pull/6807#issuecomment-2475690182

   > `Error: Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.11.3:wget (download-spark-release) on project kyuubi-download: Network is unreachable -> [Help 1]` 1.11.3 is not cached on Maven repo mirror. Let's rerun the CI tests later.
   
   How can i rerun the CI tests manually without submitting a commit?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [BUILD] Bump maven plugin download version to 1.11.2 [kyuubi]

Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #6807:
URL: https://github.com/apache/kyuubi/pull/6807#discussion_r1841586328


##########
pom.xml:
##########
@@ -228,7 +228,7 @@
         <jars.target.dir>${project.build.directory}/scala-${scala.binary.version}/jars</jars.target.dir>
 
         <maven.plugin.build.helper.version>3.3.0</maven.plugin.build.helper.version>
-        <maven.plugin.download.version>1.8.1</maven.plugin.download.version>
+        <maven.plugin.download.version>1.11.2</maven.plugin.download.version>

Review Comment:
   ```suggestion
           <maven.plugin.download.version>1.11.3</maven.plugin.download.version>
   ```
   1.11.3 has been just released, bring back the support for Java 8.
   https://github.com/maven-download-plugin/maven-download-plugin/releases/tag/1.11.3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [BUILD] Bump maven download plugin from 1.8.1 to 1.11.3 [kyuubi]

Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #6807:
URL: https://github.com/apache/kyuubi/pull/6807#issuecomment-2475474905

    `Error:  Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.11.3:wget (download-spark-release) on project kyuubi-download: Network is unreachable -> [Help 1]`
   1.11.3 is not cached on Maven repo mirror. Let's rerun the CI tests later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [BUILD] Bump maven download plugin from 1.8.1 to 1.11.3 [kyuubi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6807:
URL: https://github.com/apache/kyuubi/pull/6807#issuecomment-2477940031

   ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6807?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 0.00%. Comparing base [(`dddb037`)](https://app.codecov.io/gh/apache/kyuubi/commit/dddb03722dd33578c2839011c84647d16f7037a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6582a19`)](https://app.codecov.io/gh/apache/kyuubi/commit/6582a194cef835599c852439a6d36dfcb2f819d8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 7 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@          Coverage Diff           @@
   ##           master   #6807   +/-   ##
   ======================================
     Coverage    0.00%   0.00%           
   ======================================
     Files         687     687           
     Lines       42442   42442           
     Branches     5793    5793           
   ======================================
     Misses      42442   42442           
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/6807?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org