[GitHub] [flink] slinkydeveloper commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

[GitBox <gi...@apache.org>]

slinkydeveloper commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r727828034



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -894,6 +891,13 @@ protected Configuration configuration() {
         private final List<Object> columnData = new ArrayList<>();
         private final List<AbstractDataType<?>> columnTypes = new ArrayList<>();
         private final List<Object> expectedValues = new ArrayList<>();
+        private final List<TestType> testTypes = new ArrayList<>();
+
+        private enum TestType {
+            RESULT,
+            ERROR_SQL,
+            ERROR_TABLE_API

Review comment:
       Why the test case does any distinction between error in SQL and Table API? Isn't a cast invalid both for SQL and Table API? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org