You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/05/14 12:35:43 UTC
[GitHub] [carbondata] Sunt-ing opened a new pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Sunt-ing opened a new pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136
### Why is this PR needed?
To improve the quality of how-to-contribute-to-apache-carbondata.md.
### What changes were proposed in this PR?
Syntax and format changes.
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-841269307
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853682436
Fix done. @Indhumathi27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853882754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853746591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851521015
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3707/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r640259465
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -20,7 +20,7 @@
The Apache CarbonData community welcomes all kinds of contributions from anyone with a passion for
faster data format! Apache CarbonData is a new file format for faster interactive query using
advanced columnar storage, index, compression and encoding techniques to improve computing
-efficiency,in turn it will help speedup queries an order of magnitude faster over PetaBytes of data.
+efficiency, in turn it will help speedup queries an order of magnitude faster over PetaBytes of data.
Review comment:
```suggestion
efficiency, in turn it will help speedup queries by order of magnitude faster over PetaBytes of data.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851587212
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3716/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r644504897
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -7,7 +7,7 @@
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-
+
Review comment:
Please rever this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r642515389
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -189,4 +189,4 @@ From another local branch, run:
$ git fetch --all
$ git branch -d <my-branch>
$ git push <GitHub_user> --delete <my-branch>
-```
\ No newline at end of file
+```
Review comment:
please revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-841272690
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5370/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-850992874
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3703/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853746591
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851522582
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5451/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-854413455
LGTM. Thankyou for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r644504897
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -7,7 +7,7 @@
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-
+
Review comment:
Please rever this change
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -189,4 +189,4 @@ From another local branch, run:
$ git fetch --all
$ git branch -d <my-branch>
$ git push <GitHub_user> --delete <my-branch>
-```
\ No newline at end of file
+```
Review comment:
Looks like it is not reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851542740
A little weird... should be fine now. @Indhumathi27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853821655
Sorry for the long-time bother, but I do think it should be fine now. @Indhumathi27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-849281190
@Indhumathi27 Could you please review this PR? I believe this PR is very simple and thus will not take you much time to review. Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-850980423
@Indhumathi27 Hello, I have updated this PR, please check it at your convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851588490
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5460/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851463354
@Indhumathi27 Finished. And PR-4135 has been closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-851207798
@Sunt-ing Since PR-4135, is also documentation related changes, can you please keep one PR(either 4136/4135)
for documentation change and list all the changes in the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r644724776
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -189,4 +189,4 @@ From another local branch, run:
$ git fetch --all
$ git branch -d <my-branch>
$ git push <GitHub_user> --delete <my-branch>
-```
\ No newline at end of file
+```
Review comment:
Looks like it is not reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853747798
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3739/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r640259094
##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -189,4 +189,4 @@ From another local branch, run:
$ git fetch --all
$ git branch -d <my-branch>
$ git push <GitHub_user> --delete <my-branch>
-```
\ No newline at end of file
+```
Review comment:
please revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853682436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-850992264
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5447/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-854413455
LGTM. Thankyou for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org