You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Bruno Dumon (JIRA)" <ji...@apache.org> on 2011/06/08 14:29:58 UTC

[jira] [Created] (HBASE-3961) Add Delete.setWriteToWAL functionality

Add Delete.setWriteToWAL functionality
--------------------------------------

                 Key: HBASE-3961
                 URL: https://issues.apache.org/jira/browse/HBASE-3961
             Project: HBase
          Issue Type: Improvement
          Components: client, regionserver
            Reporter: Bruno Dumon


For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.

The attached patch introduces this.

This changes the serialization format of Delete, so bumped up the version.

I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-3961) Add Delete.setWriteToWAL functionality

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell resolved HBASE-3961.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.92.0

Committed. Relevant local tests pass ok.

> Add Delete.setWriteToWAL functionality
> --------------------------------------
>
>                 Key: HBASE-3961
>                 URL: https://issues.apache.org/jira/browse/HBASE-3961
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Bruno Dumon
>            Assignee: Bruno Dumon
>             Fix For: 0.92.0
>
>         Attachments: delete-writetowal-patch.txt
>
>
> For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.
> The attached patch introduces this.
> This changes the serialization format of Delete, so bumped up the version.
> I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3961) Add Delete.setWriteToWAL functionality

Posted by "Bruno Dumon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Dumon updated HBASE-3961:
-------------------------------

    Attachment: delete-writetowal-patch.txt

patch against trunk r1133369

> Add Delete.setWriteToWAL functionality
> --------------------------------------
>
>                 Key: HBASE-3961
>                 URL: https://issues.apache.org/jira/browse/HBASE-3961
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Bruno Dumon
>         Attachments: delete-writetowal-patch.txt
>
>
> For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.
> The attached patch introduces this.
> This changes the serialization format of Delete, so bumped up the version.
> I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-3961) Add Delete.setWriteToWAL functionality

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell reassigned HBASE-3961:
-------------------------------------

    Assignee: Bruno Dumon

> Add Delete.setWriteToWAL functionality
> --------------------------------------
>
>                 Key: HBASE-3961
>                 URL: https://issues.apache.org/jira/browse/HBASE-3961
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Bruno Dumon
>            Assignee: Bruno Dumon
>         Attachments: delete-writetowal-patch.txt
>
>
> For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.
> The attached patch introduces this.
> This changes the serialization format of Delete, so bumped up the version.
> I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3961) Add Delete.setWriteToWAL functionality

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050988#comment-13050988 ] 

Hudson commented on HBASE-3961:
-------------------------------

Integrated in HBase-TRUNK #1976 (See [https://builds.apache.org/job/HBase-TRUNK/1976/])
    

> Add Delete.setWriteToWAL functionality
> --------------------------------------
>
>                 Key: HBASE-3961
>                 URL: https://issues.apache.org/jira/browse/HBASE-3961
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Bruno Dumon
>            Assignee: Bruno Dumon
>             Fix For: 0.92.0
>
>         Attachments: delete-writetowal-patch.txt
>
>
> For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.
> The attached patch introduces this.
> This changes the serialization format of Delete, so bumped up the version.
> I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-3961) Add Delete.setWriteToWAL functionality

Posted by "mingjian (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046513#comment-13046513 ] 

mingjian commented on HBASE-3961:
---------------------------------

Thanks for Bruno. It's very useful

> Add Delete.setWriteToWAL functionality
> --------------------------------------
>
>                 Key: HBASE-3961
>                 URL: https://issues.apache.org/jira/browse/HBASE-3961
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Bruno Dumon
>            Assignee: Bruno Dumon
>             Fix For: 0.92.0
>
>         Attachments: delete-writetowal-patch.txt
>
>
> For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.
> The attached patch introduces this.
> This changes the serialization format of Delete, so bumped up the version.
> I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3961) Add Delete.setWriteToWAL functionality

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045990#comment-13045990 ] 

Andrew Purtell commented on HBASE-3961:
---------------------------------------

+1
Going to commit when local tests pass.

Thanks for the patch Bruno!

> Add Delete.setWriteToWAL functionality
> --------------------------------------
>
>                 Key: HBASE-3961
>                 URL: https://issues.apache.org/jira/browse/HBASE-3961
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Bruno Dumon
>         Attachments: delete-writetowal-patch.txt
>
>
> For puts, write to WAL can be disabled, but for deletes this functionality is missing. The regionserver internally already passes around a writeToWAL flag, but it is not possible to set this from the client.
> The attached patch introduces this.
> This changes the serialization format of Delete, so bumped up the version.
> I verified manually that the WAL is indeed not growing when writeToWAL is set to false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira