[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7580: get the right controll cidr

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #7580:
URL: https://github.com/apache/cloudstack/pull/7580#discussion_r1214212613


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java:
##########
@@ -65,10 +65,7 @@ public void configure(Map<String, Object> params) throws ConfigurationException
 
         String networkScriptsDir = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.NETWORK_SCRIPTS_DIR);
 
-        String controlCidr = (String)params.get("control.cidr");
-        if (StringUtils.isNotBlank(controlCidr)) {
-            _controlCidr = controlCidr;
-        }
+        _controlCidr = getControllCidr(_controlCidr, params);

Review Comment:
   I think the double l is correct English (you dutchy;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org