[GitHub] [druid] gianm edited a comment on pull request #11170: Fix is null selector returning incorrect value for Long data type

[GitBox <gi...@apache.org>]

gianm edited a comment on pull request #11170:
URL: https://github.com/apache/druid/pull/11170#issuecomment-844663905


   > CI cannot possibly pass the coverage check for the processing module, which cannot be satisfied when druid.generic.useDefaultValueForNull=true because the changed code-path only affects sql compatible null handling mode, so i think we can ignore it.
   
   The two processing module tests are failed due to coverage checks, but as you point out, they can't possibly pass coverage. I checked and the unit tests actually did pass, so I think we're ok to override the coverage check.
   
   > I've triggered the integration tests to run anyway, but think we can merge after they finish up.
   
   They just finished, except for "(Compile=openjdk8, Run=openjdk11, ZK=3.4) leadership and high availability integration tests", which failed. I can't see how this patch would affect it, though, so I'll override this one too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org