[jira] [Commented] (HADOOP-14569) NativeAzureFileSystem, AzureBlobStorageTestAccount to have useful toString() values

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297069#comment-16297069 ] 

Steve Loughran commented on HADOOP-14569:
-----------------------------------------

sorry, I'd missed this!

thanks for this. I'm about to fiddle with the JIRA settings to have yetus do a test run. I expect it will reject the one line {{if(container == null) return null;}} clauses

Better to have a multiline condition

{code}
if (container == null) {
  return none;
}
{code}

Otherwise, code LGTM


> NativeAzureFileSystem, AzureBlobStorageTestAccount to have useful toString() values
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-14569
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14569
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 2.8.1
>            Reporter: Steve Loughran
>            Assignee: Amit Singh
>            Priority: Minor
>         Attachments: HADOOP-14569.001.patch, formatted_output
>
>
> {{NativeAzureFileSystem.toString()}},  and {{AzureBlobStorageTestAccount.toString()}} should return data meaningful in logging & test runs
> * account name
> * container name/status
> * ideally, FS instrumentation statistics
> * + not to NPE if invoked before calling FileSystem.initialize(), or after being closed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org