You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/02/20 02:10:27 UTC
Review Request 43778: Added '/create-volumes' tests with multiple
roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/
-----------------------------------------------------------
Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591
Repository: mesos
Description
-------
Added '/create-volumes' tests with multiple roles.
Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
Diffs
-----
src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
Diff: https://reviews.apache.org/r/43778/diff/
Testing
-------
Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
Thanks,
Greg Mann
Re: Review Request 43778: Added '/create-volumes' tests with multiple
roles.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/#review120832
-----------------------------------------------------------
src/tests/persistent_volume_endpoints_tests.cpp (line 839)
<https://reviews.apache.org/r/43778/#comment182344>
`const`
src/tests/persistent_volume_endpoints_tests.cpp (line 874)
<https://reviews.apache.org/r/43778/#comment182348>
Unused variable.
src/tests/persistent_volume_endpoints_tests.cpp (line 1066)
<https://reviews.apache.org/r/43778/#comment182349>
Unused variable.
src/tests/persistent_volume_endpoints_tests.cpp (line 1082)
<https://reviews.apache.org/r/43778/#comment182350>
`response` seems a bit more concise.
- Neil Conway
On Feb. 24, 2016, 6:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43778/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 6:42 p.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/create-volumes' tests with multiple roles.
>
> Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
>
> Diff: https://reviews.apache.org/r/43778/diff/
>
>
> Testing
> -------
>
> Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43778: Added '/create-volumes' tests with multiple
roles.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/#review120920
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Feb. 26, 2016, 4:56 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43778/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 4:56 p.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/create-volumes' tests with multiple roles.
>
> Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
>
> Diff: https://reviews.apache.org/r/43778/diff/
>
>
> Testing
> -------
>
> Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43778: Added '/create-volumes' tests with multiple
roles.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/#review120939
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 26, 2016, 4:56 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43778/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 4:56 p.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/create-volumes' tests with multiple roles.
>
> Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
>
> Diff: https://reviews.apache.org/r/43778/diff/
>
>
> Testing
> -------
>
> Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43778: Added '/create-volumes' tests with multiple
roles.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 4:56 p.m.)
Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Addressed comments.
Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591
Repository: mesos
Description
-------
Added '/create-volumes' tests with multiple roles.
Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
Diffs (updated)
-----
src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
Diff: https://reviews.apache.org/r/43778/diff/
Testing
-------
Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
Thanks,
Greg Mann
Re: Review Request 43778: Added '/create-volumes' tests with multiple
roles.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 6:42 p.m.)
Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591
Repository: mesos
Description
-------
Added '/create-volumes' tests with multiple roles.
Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
Diffs (updated)
-----
src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
Diff: https://reviews.apache.org/r/43778/diff/
Testing
-------
Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
Thanks,
Greg Mann
Re: Review Request 43778: Added '/create-volumes' tests with multiple
roles.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 7:58 p.m.)
Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591
Repository: mesos
Description
-------
Added '/create-volumes' tests with multiple roles.
Operators may create volumes for multiple roles in the same operation; this patch adds tests to confirm correct behavior of authorization in this case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
Diffs (updated)
-----
src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924
Diff: https://reviews.apache.org/r/43778/diff/
Testing
-------
Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed.
Thanks,
Greg Mann