You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/09/06 05:31:00 UTC

[GitHub] zeppelin pull request #1405: Remove --safe from building instruction

GitHub user corneadoug opened a pull request:

    https://github.com/apache/zeppelin/pull/1405

    Remove --safe from building instruction

    ### What is this PR for?
    Usually in order to push jekyll code to github pages, it will compile using the `--safe`
    One drawback is that you cannot use any plugins.
    
    After working on PR #1356 and introduction a plugin, using the build line with `--safe` specified in the README is failing.
    
    However in our case, we are not forced to use that flag, since we are sending the compiled website directly to the Apache SVN, and I was able to confirm that fact when I sent the updated website to the SVN and it was rendered correctly
    
    ### What type of PR is it?
    Documentation
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin update/buildCommandLine

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1405
    
----
commit acd0b04117cedae54939d71119650d0cdb480698
Author: Damien CORNEAU <co...@gmail.com>
Date:   2016-09-06T05:23:47Z

    Remove --safe from building instruction

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1405: Update Zeppelin Website building instructions

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1405
  
    Let's Merge This since #1410 was merged too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1405: Update Zeppelin Website building instructions

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1405
  
    @corneadoug Yeah please do :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1405: Update Zeppelin Website building instructions

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1405
  
    @corneadoug There is one more `--safe` in here : [https://github.com/apache/zeppelin/blob/gh-pages/contribution/documentation.md#deploy-to-asf-svnpubsub-infra](https://github.com/apache/zeppelin/blob/gh-pages/contribution/documentation.md#deploy-to-asf-svnpubsub-infra)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1405: Update Zeppelin Website building instructions

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---