You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Yasuhiro Matsuda <ya...@gmail.com> on 2015/02/19 18:51:46 UTC

Review Request 31199: Patch for KAFKA-1965

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31199/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1965
    https://issues.apache.org/jira/browse/KAFKA-1965


Repository: kafka


Description
-------

leaner DelayedItem


Diffs
-----

  core/src/main/scala/kafka/utils/DelayedItem.scala a4e0dabc858bc0081ba4fc0deea203bebd8bbf6b 

Diff: https://reviews.apache.org/r/31199/diff/


Testing
-------


Thanks,

Yasuhiro Matsuda

Re: Review Request 31199: Patch for KAFKA-1965

Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31199/#review73168
-----------------------------------------------------------

Ship it!


minor comment.


core/src/main/scala/kafka/utils/DelayedItem.scala
<https://reviews.apache.org/r/31199/#comment119405>

    May be better to name the argument delayMs


- Joel Koshy


On Feb. 19, 2015, 5:51 p.m., Yasuhiro Matsuda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31199/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 5:51 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1965
>     https://issues.apache.org/jira/browse/KAFKA-1965
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> leaner DelayedItem
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/utils/DelayedItem.scala a4e0dabc858bc0081ba4fc0deea203bebd8bbf6b 
> 
> Diff: https://reviews.apache.org/r/31199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yasuhiro Matsuda
> 
>

Re: Review Request 31199: Patch for KAFKA-1965

Posted by Yasuhiro Matsuda <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31199/
-----------------------------------------------------------

(Updated Feb. 20, 2015, 11:08 p.m.)


Review request for kafka.


Bugs: KAFKA-1965
    https://issues.apache.org/jira/browse/KAFKA-1965


Repository: kafka


Description (updated)
-------

renamed variables


Diffs (updated)
-----

  core/src/main/scala/kafka/utils/DelayedItem.scala a4e0dabc858bc0081ba4fc0deea203bebd8bbf6b 

Diff: https://reviews.apache.org/r/31199/diff/


Testing
-------


Thanks,

Yasuhiro Matsuda

Re: Review Request 31199: Patch for KAFKA-1965

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31199/#review73253
-----------------------------------------------------------

Ship it!


Other than the minor renaming comment, the patch LGTM. I can help check in the updated patch


core/src/main/scala/kafka/utils/DelayedItem.scala
<https://reviews.apache.org/r/31199/#comment119532>

    We have been following a convention of appending the timeunit for variables that hold a timestamp value. 
    So I'd suggest, rename-
    due -> dueMs
    delay -> delayMs


- Neha Narkhede


On Feb. 19, 2015, 5:51 p.m., Yasuhiro Matsuda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31199/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 5:51 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1965
>     https://issues.apache.org/jira/browse/KAFKA-1965
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> leaner DelayedItem
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/utils/DelayedItem.scala a4e0dabc858bc0081ba4fc0deea203bebd8bbf6b 
> 
> Diff: https://reviews.apache.org/r/31199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yasuhiro Matsuda
> 
>