You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/27 04:49:00 UTC
[GitHub] [inlong] Oneal65 opened a new pull request, #5229: [INLONG-5211][Sort] Replace 1.3.0-snapshot with project.version
Oneal65 opened a new pull request, #5229:
URL: https://github.com/apache/inlong/pull/5229
### Prepare a Pull Request
- Fixes #5211
### Motivation
Replace 1.3.0-snapshot with project.version
### Modifications
change
inlong-sdk/sort-sdk/pom.xml
inlong-sort/sort-connectors/elasticsearch-6/pom.xml
inlong-sort/sort-connectors/elasticsearch-7/pom.xml
inlong-sort/sort-connectors/iceberg-dlc/pom.xml
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5229: [INLONG-5211][Sort] Replace 1.3.0-snapshot with project.version
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5229:
URL: https://github.com/apache/inlong/pull/5229#discussion_r930622302
##########
inlong-sdk/sort-sdk/pom.xml:
##########
@@ -27,7 +27,7 @@
<version>1.3.0-SNAPSHOT</version>
</parent>
<artifactId>sort-sdk</artifactId>
- <version>1.3.0-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5229: [INLONG-5211][Sort] Replace 1.3.0-snapshot with project.version
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5229:
URL: https://github.com/apache/inlong/pull/5229#discussion_r930620945
##########
inlong-sdk/sort-sdk/pom.xml:
##########
@@ -27,7 +27,7 @@
<version>1.3.0-SNAPSHOT</version>
</parent>
<artifactId>sort-sdk</artifactId>
- <version>1.3.0-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
This version definition is unnecessary, just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5229: [INLONG-5211][Sort] Replace 1.3.0-snapshot with project.version
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5229:
URL: https://github.com/apache/inlong/pull/5229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org