[jira] [Work logged] (ARTEMIS-3385) Management changes can be reverted by XML update

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3385?focusedWorklogId=632958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632958 ]

ASF GitHub Bot logged work on ARTEMIS-3385:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Aug/21 14:21
            Start Date: 03/Aug/21 14:21
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on a change in pull request #3653:
URL: https://github.com/apache/activemq-artemis/pull/3653#discussion_r681807480



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
##########
@@ -197,6 +197,237 @@ public void run() {
       }
    }
 
+   @Test
+   public void testRedeploySecuritySettings() throws Exception {
+      Path brokerXML = getTestDirfile().toPath().resolve("broker.xml");
+      URL url1 = RedeployTest.class.getClassLoader().getResource("reload-security-settings.xml");
+      URL url2 = RedeployTest.class.getClassLoader().getResource("reload-security-settings-updated.xml");
+      Files.copy(url1.openStream(), brokerXML);
+
+      EmbeddedActiveMQ embeddedActiveMQ = new EmbeddedActiveMQ();
+      embeddedActiveMQ.setConfigResourcePath(brokerXML.toUri().toString());
+      embeddedActiveMQ.start();
+
+      final ReusableLatch latch = new ReusableLatch(1);
+
+      Runnable tick = new Runnable() {
+         @Override
+         public void run() {
+            latch.countDown();
+         }
+      };
+
+      embeddedActiveMQ.getActiveMQServer().getReloadManager().setTick(tick);

Review comment:
       setTick(latch::countDown) would been nicer..  no need to make the change though as it's just a test. (just an optional comment)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 632958)
    Time Spent: 20m  (was: 10m)

> Management changes can be reverted by XML update
> ------------------------------------------------
>
>                 Key: ARTEMIS-3385
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3385
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Durable changes made via the management API (e.g. adding security-settings, adding address-settings, adding diverts) can be reverted when reloading the XML at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)