You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by animenon <gi...@git.apache.org> on 2017/09/22 02:43:16 UTC
[GitHub] spark pull request #19315: Updated english.txt word ordering
GitHub user animenon opened a pull request:
https://github.com/apache/spark/pull/19315
Updated english.txt word ordering
Ordered alphabetically, for better readability.
## What changes were proposed in this pull request?
Alphabetical ordering of the stop words.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/animenon/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19315
----
commit 57c282721c63487a82bdd6959c6ff5f6ce9f66ad
Author: Anirudh <an...@mail.com>
Date: 2017-09-22T02:40:30Z
Updated english.txt word ordering
Ordered alphabetically, for better readability.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19315: [MINOR][ML]Updated english.txt word ordering
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19315
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19315: [MINOR][ML]Updated english.txt word ordering
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19315
Just ctrl-F and find?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19315: [MINOR][ML]Updated english.txt word ordering
Posted by animenon <gi...@git.apache.org>.
Github user animenon commented on the issue:
https://github.com/apache/spark/pull/19315
Right, but if you want to check a few things together like "who", "who's", "why", "when", etc you will have to do many finds; but in an ordered document it would be much easier.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19315: Updated english.txt word ordering
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19315
@animenon can you please fix the PR title like what other PR did. Also is this only for better readability or do you fix any other issue? IMO, I found that previous txt is more readable than your change, since they're ordered by different kind.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19315: Updated english.txt word ordering
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19315
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org