You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by holdenk <gi...@git.apache.org> on 2016/11/04 20:59:06 UTC

[GitHub] kafka pull request #2104: [KAFKA-4380] Remove cleanshutdownfile

GitHub user holdenk opened a pull request:

    https://github.com/apache/kafka/pull/2104

    [KAFKA-4380] Remove cleanshutdownfile

    This PR removes the cleanshutdownfile as suggested in the code comments as a TODO.
    
    Use of this seems to be well covered by existing tests (some of which needed to be updated).
    
    The gradlew unit tests pass locally on my machine, but since this is my first (small) PR to Kafka I may have left something out.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/holdenk/kafka KAFKA-4380-remove-cleanshutdownfile

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2104
    
----
commit 157b8523ac5de7f8c954889f0a719b956810fb76
Author: Holden Karau <ho...@us.ibm.com>
Date:   2016-09-28T20:28:31Z

    Get rid of CleanShutdownFile now that we are well past 0.8.2 :)

commit 245814cfbf36b19fdeab7900de0e56386a62f6f6
Author: Holden Karau <ho...@us.ibm.com>
Date:   2016-11-01T15:34:10Z

    More fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2104: [KAFKA-4380] Remove cleanshutdownfile

Posted by holdenk <gi...@git.apache.org>.
Github user holdenk closed the pull request at:

    https://github.com/apache/kafka/pull/2104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---