You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/05 14:22:18 UTC

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #5806: [IOTDB-3104] Add Consensus Module StateMachine Event API

SzyWilliam commented on code in PR #5806:
URL: https://github.com/apache/iotdb/pull/5806#discussion_r865964069


##########
consensus/src/main/java/org/apache/iotdb/consensus/ratis/ApplicationStateMachineProxy.java:
##########
@@ -159,4 +168,23 @@ private void loadSnapshot(File latestSnapshotDir) {
   public StateMachineStorage getStateMachineStorage() {
     return snapshotStorage;
   }
+

Review Comment:
   Should we add @Override annotation to indicate this method is inherited from ratis.statemachine.enventApi?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org