You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/05/14 00:05:46 UTC

svn commit: r537663 - in /jakarta/jmeter/branches/rel-2-2: src/core/org/apache/jmeter/JMeter.java xdocs/changes.xml

Author: sebb
Date: Sun May 13 15:05:45 2007
New Revision: 537663

URL: http://svn.apache.org/viewvc?view=rev&rev=537663
Log:
Bug 24684 - remote startup problems if spaces in the path of the jmeter

Modified:
    jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/JMeter.java
    jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml

Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/JMeter.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/JMeter.java?view=diff&rev=537663&r1=537662&r2=537663
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/JMeter.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/JMeter.java Sun May 13 15:05:45 2007
@@ -294,6 +294,19 @@
 			} else if (parser.getArgumentById(HELP_OPT) != null) {
 				System.out.println(JMeterUtils.getResourceFileAsText("org/apache/jmeter/help.txt"));// $NON-NLS-1$
 			} else if (parser.getArgumentById(SERVER_OPT) != null) {
+                // We need to check if the JMeter home contains spaces in the path,
+                // because then we will not be able to bind to RMI registry, see
+                // Java bug id 4496398
+                File jmeterHome = new File(JMeterUtils.getJMeterHome());
+                if(!jmeterHome.toURL().equals(jmeterHome.toURI().toURL())) {
+                    // Just warn user, and exit, no reason to continue, since we will
+                    // not be able to bind to RMI registry, until Java bug 4496398 is fixed
+                    System.out.println("JMeter path cannot contain spaces when run in server mode."); // $NON-NLS-1$
+                    System.out.println("JMeterHome is "  + jmeterHome.getAbsolutePath()); // $NON-NLS-1$
+                    log.error("JMeter path cannot contain spaces when run in server mode : " + jmeterHome.getAbsolutePath()); // $NON-NLS-1$
+                    System.exit(-1);
+                }
+                // Start the server
 				startServer(JMeterUtils.getPropDefault("server_port", 0));// $NON-NLS-1$
 				startOptionalServers();
 			} else if (parser.getArgumentById(NONGUI_OPT) == null) {

Modified: jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml?view=diff&rev=537663&r1=537662&r2=537663
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml (original)
+++ jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml Sun May 13 15:05:45 2007
@@ -229,6 +229,7 @@
 <li>Bug 25441 - TestPlan changes sometimes detected incorrectly (isDirty)</li>
 <li>Bug 39734 - Listeners shared after copy/paste operation</li>
 <li>Bug 40851 - Loop controller with 0 iterations, stops evaluating the iterations field</li>
+<li>Bug 24684 - remote startup problems if spaces in the path of the jmeter</li>
 </ul>
 
 <h3>Version 2.2</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org