You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/23 20:37:19 UTC

[GitHub] lovelle commented on issue #3413: Fix: init of subcription rateLimiter to avoid race-condition and NPE

lovelle commented on issue #3413: Fix: init of subcription rateLimiter to avoid race-condition and NPE
URL: https://github.com/apache/pulsar/pull/3413#issuecomment-456956734
 
 
   Excellent solution! just a question/proposal, has anyone ever considered of using annotations to document better thread safety like `@ThreadSafe` at a class level? A lot of people use [jcip-annotations](https://mvnrepository.com/artifact/net.jcip/jcip-annotations) for this purpose and gives a clearer visibility about thread safety.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services