[GitHub] [hbase] ZhaoBQ commented on a change in pull request #615: HBASE-22975 Add read and write QPS metrics at server level and table level

[GitBox <gi...@apache.org>]

ZhaoBQ commented on a change in pull request #615: HBASE-22975 Add read and write QPS metrics at server level and table level
URL: https://github.com/apache/hbase/pull/615#discussion_r324957691
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 ##########
 @@ -4075,6 +4075,10 @@ public void completeMiniBatchOperations(
 
         if (!initialized) {
           this.writeRequestsCount.add(batchOp.size());
+          if (rsServices != null && rsServices.getMetrics() != null) {
+            rsServices.getMetrics().updateServerWriteQueryPerSecond(this.htableDescriptor.
 
 Review comment:
   Incre is usually used for simple numerical increments, but Meter is a complex data structure. What about updateWriteQueryMeter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services