You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/22 09:28:25 UTC
[GitHub] [rocketmq] xiaoyifang opened a new issue, #5766: msg may be null
xiaoyifang opened a new issue, #5766:
URL: https://github.com/apache/rocketmq/issues/5766
[rocketmq] client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java (Lines 105-109)
```
try {
pushConsumer.sendMessageBack(msg, 3);
log.info("send expire msg back. topic={}, msgId={}, storeHost={}, queueId={}, queueOffset={}", msg.getTopic(), msg.getMsgId(), msg.getStoreHost(), msg.getQueueId(), msg.getQueueOffset());
```
[Open in IDE](https://api.codestream.com/c/Y6QT9LFmIIrg5Cwr/YSzoBANQR5Wxx_pb_Jq7pQ?marker=63a423363f6313def93f6be2&ide=default&src=GitHub) ยท [Open on GitHub](https://github.com/apache/rocketmq/blob/a68078fef8315a0deeae32af42a029ccd2fa76a4/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java#L105-L109)
<sup>Created from JetBrains using [CodeStream](https://codestream.com/?utm_source=cs&utm_medium=issue&utm_campaign=github)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on issue #5766: msg may be null
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on issue #5766:
URL: https://github.com/apache/rocketmq/issues/5766#issuecomment-1363491880
IMO, This is just an ide check, which is not null from a business logic point of view
Please let me know if I am missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyifang closed issue #5766: msg may be null
Posted by GitBox <gi...@apache.org>.
xiaoyifang closed issue #5766: msg may be null
URL: https://github.com/apache/rocketmq/issues/5766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyifang commented on issue #5766: msg may be null
Posted by GitBox <gi...@apache.org>.
xiaoyifang commented on issue #5766:
URL: https://github.com/apache/rocketmq/issues/5766#issuecomment-1364450910
`msg = msgTreeMap.firstEntry().getValue();` this line may return null ,though in reality it is not possible.
and if exception is throw , `msg` may still be null
and the logic is a little complex ,I think it can be rewrite with a more readable code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhimins closed issue #5766: msg may be null
Posted by GitBox <gi...@apache.org>.
lizhimins closed issue #5766: msg may be null
URL: https://github.com/apache/rocketmq/issues/5766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org