You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/15 19:05:43 UTC
[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #59: [MJAVADOC-662] The fix operation wrongly generate illegal javadoc for static final fields.
XenoAmess commented on a change in pull request #59:
URL: https://github.com/apache/maven-javadoc-plugin/pull/59#discussion_r543610570
##########
File path: src/test/resources/unit/fix-test/expected/src/main/java/fix/test/ClassWithJavadoc.java
##########
@@ -451,6 +451,21 @@ public void testException3()
{
throw new Exception();
}
+
+ /**
+ * to test if it will handle static final field correctly.
+ */
+ public static final int TEST_STATIC_FINAL_FIELD_0 = 1 << 2;
Review comment:
1<<4 is simple but think about 1<<16.
##########
File path: src/test/resources/unit/fix-test/expected/src/main/java/fix/test/ClassWithJavadoc.java
##########
@@ -451,6 +451,21 @@ public void testException3()
{
throw new Exception();
}
+
+ /**
+ * to test if it will handle static final field correctly.
+ */
+ public static final int TEST_STATIC_FINAL_FIELD_0 = 1 << 2;
Review comment:
@elharo 1<<4 is simple but think about 1<<16.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org