[GitHub] [hbase] apurtell commented on a change in pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #1783:
URL: https://github.com/apache/hbase/pull/1783#discussion_r430737665



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -695,6 +695,7 @@ void sawNoSuchFamily() {
   private RegionCoprocessorHost coprocessorHost;
 
   private TableDescriptor htableDescriptor = null;
+  private ThreadPoolExecutor storeFileOpenAndCloseThreadPool;

Review comment:
       Why is this shared at the Region level. Shouldn't it be at the Store level (in HStore)?
   
   What does sharing at the region level gain us? Are you attempting to evenly round-robin store open work over all opening stores in the region? Just sharing an executor at region level won't do this. If the underlying stores are skewed the order in which runnables are submitted to the executor will share the skew. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org