You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jasonli-db (via GitHub)" <gi...@apache.org> on 2023/08/11 20:52:30 UTC
[GitHub] [spark] jasonli-db opened a new pull request, #42459: [SPARK-44770][WEBUI] Add a displayOrder variable to WebUITab to specify the order in which tabs appear
jasonli-db opened a new pull request, #42459:
URL: https://github.com/apache/spark/pull/42459
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Add a displayOrder variable to WebUITab to specify the order in which tabs appear. Currently, the tabs are ordered by when they get attached, which isn't always desired. The default is MIN_VALUE, meaning if it's not specified, it will appear in the order added before any tabs with a non-default displayOrder.
### Why are the changes needed?
These changes allow control over the order which tabs appear in the UI. Currently, the tabs are ordered by when they get attached, but this doesn't always match the desired order. For example, we would like to have the SQL Tab appear before the Connect tab; however, based on the code flow, the Connect tab will be attached first and with the current logic, that tab would also appear first.
### Does this PR introduce _any_ user-facing change?
Yes, minor user-facing change affecting the order in which tabs appear in the Spark UI
### How was this patch tested?
Manually tested
Before:
<img width="1696" alt="Screenshot 2023-08-10 at 3 54 26 PM" src="https://github.com/apache/spark/assets/65624911/a04ac6a9-c845-4a13-8780-ffe85de15285">
After:
<img width="1679" alt="Screenshot 2023-08-10 at 3 54 42 PM" src="https://github.com/apache/spark/assets/65624911/fb332f73-5e3e-4b03-adfc-15402db01197">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #42459: [SPARK-44770][WEBUI] Add a displayOrder variable to WebUITab to specify the order in which tabs appear
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #42459:
URL: https://github.com/apache/spark/pull/42459#issuecomment-1675532858
Thanks, merging to branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #42459: [SPARK-44770][WEBUI] Add a displayOrder variable to WebUITab to specify the order in which tabs appear
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang closed pull request #42459: [SPARK-44770][WEBUI] Add a displayOrder variable to WebUITab to specify the order in which tabs appear
URL: https://github.com/apache/spark/pull/42459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org