[GitHub] [daffodil] tuxji opened a new pull request #780: Standardize licenses and notices

[GitBox <gi...@apache.org>]

tuxji opened a new pull request #780:
URL: https://github.com/apache/daffodil/pull/780


   Bring changes that I just made to daffodil-vscode's bin.LICENSE and
   bin.NOTICE back to daffodil's bin.LICENSE and bin.NOTICE since we want
   to standardize both repos' licenses and notices using the same
   formatting, ordering, and wording to make future comparisons easier.
   
   NOTICE: Update Scala copyright years in sub-notice attributing
   UniquenessCache.scala to match bin.NOTICE.
   
   bin.LICENSE: Remove 'lib/' from all filenames.  If listing individual
   files from a jar, list jar filename first followed by " with:" and
   individual files on subsequent lines.  Change next line's wording from
   "This product bundles '...' with the above files" to "This product
   bundles '...'  from the above files."  Update ICU license (ICU 70 had
   changed parts of it).  Sort all sub-licenses alphabetically by
   filenames.
   
   bin.NOTICE: Remove 'lib/' from all filenames.  Add daffodil-lib's
   special sub-notice attributing UniquenessCache.scala to Scala library.
   No need to add sub-notices for other daffodil jars since their
   sub-notice is the same as top of NOTICE.  Merge sub-notice for
   scala-library and scala-reflect since both libraries have identical
   notices.
   
   daffodil-lib/src/main/resources/META-INF/NOTICE: Update Scala
   copyright years in sub-notice attributing UniquenessCache.scala to
   match bin.NOTICE.
   
   daffodil-schematron/src/main/resources/META-INF/LICENSE: Change
   ordering and prologue of Schematron sub-licenses to match bin.LICENSE.
   
   DAFFODIL-2680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence commented on a change in pull request #780: Standardize licenses and notices

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #780:
URL: https://github.com/apache/daffodil/pull/780#discussion_r840822804



##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -46,49 +46,74 @@ The following NOTICE information applies to binary components distributed with t
   Original source copyright:
   Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
 
-- lib/commons-io.commons-io-<VERSION>.jar
+- commons-io.commons-io-<VERSION>.jar
   Apache Commons IO
   Copyright 2002-2021 The Apache Software Foundation
 
-- lib/commons-logging.commons-logging-<VERSION>.jar
+- commons-logging.commons-logging-<VERSION>.jar
   Apache Commons Logging
   Copyright 2003-2014 The Apache Software Foundation
 
-- lib/org.apache.httpcomponents.httpclient-<VERSION>.jar
+- org.apache.daffodil.daffodil-lib-<VERSION>.jar

Review comment:
       This is interesting. We don't include other daffodil NOTICES since they are the same as the top of this NOTICE. But I guess you include this because of the Scala stuff added to the notice? This feels odd, but I'm not sure of another way to include this information, so I guess it seems fine. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org